Bug 201174 – Skip fetch event dispatching if no fetch event handler is added at script evaluation time

• Component: Service Workers
• Status: RESOLVED FIXED

[youenn fablet]

Skip fetch event dispatching if no fetch event handler is added at script evaluation time 
https://w3c.github.io/ServiceWorker/#handle-fetch step 16

[youenn fablet]

Created attachment 377326 [details]
Patch

[Chris Dumez]

Comment on attachment 377326 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377326&action=review

> Source/WebCore/workers/service/server/SWServerWorker.h:115
> +    bool shouldSkipFetchEvent() const { return m_shouldSkipHandleFetch && *m_shouldSkipHandleFetch; }

return m_shouldSkipHandleFetch.valueOr(false); would look nicer IMO.

> Source/WebCore/workers/service/server/SWServerWorker.h:135
> +    Optional<bool> m_shouldSkipHandleFetch;

Do we really need an Optional<> ? Why cannot it be a bool that is default-initialized to false? Nobody seems to rely on it being nullopt at the moment.

[youenn fablet]

Comment on attachment 377326 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377326&action=review

>> Source/WebCore/workers/service/server/SWServerWorker.h:135
>> +    Optional<bool> m_shouldSkipHandleFetch;
> 
> Do we really need an Optional<> ? Why cannot it be a bool that is default-initialized to false? Nobody seems to rely on it being nullopt at the moment.

Will change it to a bool.

[youenn fablet]

Created attachment 377575 [details]
Patch for landing

[youenn fablet]

Created attachment 377588 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 377588 [details]
Patch for landing

Clearing flags on attachment: 377588

Committed r249287: <https://trac.webkit.org/changeset/249287>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/54848514>