Bug 201170

Summary: [WebCore] DataCue should not use gcProtect / gcUnprotect
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: Web AudioAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, darin, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, mark.lam, philipj, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mark.lam: review+

Yusuke Suzuki
Reported 2019-08-26 20:13:17 PDT
JSC::gcProtect / gcUnprotect are APIs designed for JavaScriptCore.framework. It has JSLocker check and the crash in DataCue is happening now. We should use JSValueInWrappedObject instead.
Attachments
Patch (7.54 KB, patch)
2019-08-26 22:33 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (7.78 KB, patch)
2019-08-26 22:39 PDT, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-08-26 20:13:42 PDT
<rdar://problem/54733619>
Yusuke Suzuki
Comment 2 2019-08-26 22:33:56 PDT
Created attachment 377318 [details] Patch
Yusuke Suzuki
Comment 3 2019-08-26 22:39:43 PDT
Created attachment 377319 [details] Patch
Mark Lam
Comment 4 2019-08-26 23:33:13 PDT
Comment on attachment 377319 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377319&action=review r=me > Source/WebCore/ChangeLog:17 > + As a first step, this patch just converts raw JSValue + gcProtect/gcUnprotect with JSC::Strong<>. I suggest /converts/replaces/.
Yusuke Suzuki
Comment 5 2019-08-26 23:41:36 PDT
Comment on attachment 377319 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377319&action=review >> Source/WebCore/ChangeLog:17 >> + As a first step, this patch just converts raw JSValue + gcProtect/gcUnprotect with JSC::Strong<>. > > I suggest /converts/replaces/. Thanks, fixed.
Yusuke Suzuki
Comment 6 2019-08-26 23:51:54 PDT
Committed r249133: <https://trac.webkit.org/changeset/249133>
Yusuke Suzuki
Comment 7 2019-08-28 10:38:37 PDT
*** Bug 199340 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.