Bug 201154

Summary: [bmalloc] Disable IsoHeap completely if DebugHeap is enabled
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: bmallocAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, mark.lam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=201061
Attachments:
Description Flags
Patch simon.fraser: review+

Yusuke Suzuki
Reported 2019-08-26 15:02:01 PDT
When DebugHeap is enabled, we would like to get information about Malloc. In this case, enabling IsoHeap makes Malloc stack logging information broken for IsoHeaped one. This is not what we want. Given that, 1. IsoHeap is currently only used for WebCore and upper 2. Gigacage is also disabled when DebugHeap is enabled 3. The existing code is assuming that IsoHeap should be disabled when DebugHeap is enabled we should disable IsoHeap if DebugHeap is enabled.
Attachments
Patch (2.69 KB, patch)
2019-08-26 15:25 PDT, Yusuke Suzuki 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-08-26 15:08:12 PDT
We had an assertion that IsoHeap is disabled when Malloc=1 is specified. And it worked because IsoHeap is disabled when Gigacage is disabled, and Gigacage is disabled when Malloc=1 is specified. But from https://bugs.webkit.org/show_bug.cgi?id=201061, IsoHeap can become enabled while Gigacage is disabled. So now, the above invariant is now broken.
Yusuke Suzuki
Comment 2 2019-08-26 15:25:20 PDT
Created attachment 377276 [details] Patch
Yusuke Suzuki
Comment 3 2019-08-26 15:32:07 PDT
Committed r249121: <https://trac.webkit.org/changeset/249121>
Mark Lam
Comment 4 2019-08-26 15:32:14 PDT
Comment on attachment 377276 [details] Patch r=me too.
Radar WebKit Bug Importer
Comment 5 2019-08-26 15:33:24 PDT
<rdar://problem/54724969>
Note You need to log in before you can comment on or make changes to this bug.