Bug 201126 – [Xcode] Teach make(1) how to build schemes in WebKit.xcworkspace

• Component: New Bugs
• Status: NEW

[Andy Estes]

[Xcode] Teach make(1) how to build schemes in WebKit.xcworkspace

[Andy Estes]

Created attachment 377223 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 377223 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377223&action=review

> ChangeLog:10
> +        When running make(1) from the top level, it should be possible to invoke xcodebuild with the
> +        "-scheme" option to build a scheme from WebKit.xcworkspace rather than recursively invoking
> +        xcodebuild for each individual module.

Can you elaborate on why this should be possible? It's a new scenario that will have to be supported indefinitely, i.e. a liability.

> Makefile:7
> +else

Why doesn't this need an equivalent of what we have below for SDK_VARIANT?

[Andy Estes]

Comment on attachment 377223 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377223&action=review

>> ChangeLog:10
>> +        xcodebuild for each individual module.
> 
> Can you elaborate on why this should be possible? It's a new scenario that will have to be supported indefinitely, i.e. a liability.

We've already been maintaining the shared schemes in WebKit.xcworkspace, which is what seems to create the real maintenance burden here. This is just teaching make how to build like an Xcode workspace does.

I found incremental command line builds were measurably faster for me when building a scheme vs building each module recursively (in particular when the new build system is enabled).

>> Makefile:7
>> +else
> 
> Why doesn't this need an equivalent of what we have below for SDK_VARIANT?

When you build a scheme you can't also choose which individual modules to build. The assumption for SCHEME is that you've already created a scheme with targets appropriate for the specified SDK and variant.