Bug 201090

Summary:

Web Inspector: decrease horizontal padding of `WI.ScopeBar` to have more room

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

201152

Attachments:

Description	Flags
[Image] Screenshot of Issue (Network)	none
[Image] Screenshot of Issue (Elements)	none
Patch	none
[Image] After Patch is applied (Network)	none
[Image] After Patch is applied (Network)	none
[Image] After Patch is applied (Elements)	none

Devin Rousso

Reported 2019-08-23 15:07:14 PDT

Right now, the space around each item in a `WI.ScopeBar` is pretty "excessive", leading to a lot of extra whitespace that is often not used (e.g. when the filter isn't changing). We should decrease the padding so less room is used. This way, we'd have more room for other things =D

Attachments
[Image] Screenshot of Issue (Network) (617.38 KB, image/png) 2019-08-23 15:07 PDT, Devin Rousso	no flags	Details
[Image] Screenshot of Issue (Elements) (1.05 MB, image/png) 2019-08-23 15:07 PDT, Devin Rousso	no flags	Details
Patch (16.85 KB, patch) 2019-08-23 15:33 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
[Image] After Patch is applied (Network) (680.58 KB, image/png) 2019-08-23 15:33 PDT, Devin Rousso	no flags	Details
[Image] After Patch is applied (Network) (522.69 KB, image/png) 2019-08-23 15:34 PDT, Devin Rousso	no flags	Details
[Image] After Patch is applied (Elements) (570.37 KB, image/png) 2019-08-23 15:34 PDT, Devin Rousso	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2019-08-23 15:07:28 PDT

Created attachment 377159 [details] [Image] Screenshot of Issue (Network)

Devin Rousso

Comment 2 2019-08-23 15:07:46 PDT

Created attachment 377160 [details] [Image] Screenshot of Issue (Elements)

Devin Rousso

Comment 3 2019-08-23 15:33:17 PDT

Created attachment 377164 [details] Patch

Devin Rousso

Comment 4 2019-08-23 15:33:33 PDT Comment hidden (obsolete)

Created attachment 377165 [details] [Image] After Patch is applied (Network)

Devin Rousso

Comment 5 2019-08-23 15:34:22 PDT

Created attachment 377166 [details] [Image] After Patch is applied (Network)

Devin Rousso

Comment 6 2019-08-23 15:34:39 PDT

Created attachment 377167 [details] [Image] After Patch is applied (Elements)

Joseph Pecoraro

Comment 7 2019-08-24 14:50:44 PDT

Comment on attachment 377164 [details] Patch r=me - I like it. Especially in the Elements sidebar (Styles, etc). It looks a little tight in some places ("All") but most look fine. Does this affect the `( Selected Element )` bubble in the Console? That was slightly tighter than the scope bars originally.

Devin Rousso

Comment 8 2019-08-26 12:01:25 PDT

(In reply to Joseph Pecoraro from comment #7) > Does this affect the `( Selected Element )` bubble in the Console? That was slightly tighter than the scope bars originally. It does not, but I actually really like it at 4px instead of 6px :P

WebKit Commit Bot

Comment 9 2019-08-26 14:59:30 PDT

Comment on attachment 377164 [details] Patch Clearing flags on attachment: 377164 Committed r249118: <https://trac.webkit.org/changeset/249118>

WebKit Commit Bot

Comment 10 2019-08-26 14:59:32 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 11 2019-08-26 15:02:12 PDT

<rdar://problem/54723696>

Note You need to log in before you can comment on or make changes to this bug.