| Summary: | Implement layout system independent text box iterator | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, ggaren, sam, simon.fraser, webkit-bug-importer, zalan | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Antti Koivisto
2019-08-23 05:52:53 PDT
Created attachment 377124 [details]
patch
Created attachment 377125 [details]
patch
Comment on attachment 377125 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=377125&action=review > Source/WebCore/rendering/line/DisplayAccessTextBoxes.h:39 > +namespace DisplayAccess { I don't like this name for two reasons. First, "Display" can be read as a verb. Second you're not accessing displays. Display as in "display tree". But suggestions are welcome. I think I'll go with 'LineInterface' for the namespace. Can you help me understand what a LineInterface::TextBox (or DisplayAccess::TextBox) is supposed to represent. With both of those names, I can't quite wrap my head around it. (In reply to Sam Weinig from comment #6) > Can you help me understand what a LineInterface::TextBox (or > DisplayAccess::TextBox) is supposed to represent. With both of those names, > I can't quite wrap my head around it. It is an interface for accessing (layout generated) text box properties that hides the underlying data structures. There will be similar interfaces for other inline box types. Note that TextBox itself is just a temporary generated by the iterator, it is not an interesting type in itself. The goal is be able to write code that accesses line layout without having to write multiple versions for different paths (we have two and a third one on the way). Created attachment 377204 [details]
patch
Called it LineLayoutInterface Comment on attachment 377204 [details] patch Clearing flags on attachment: 377204 Committed r249084: <https://trac.webkit.org/changeset/249084> All reviewed patches have been landed. Closing bug. Comment on attachment 377204 [details]
patch
I would prefer we avoid "interface" in names. See VideoFullscreenInterface, for which I can never grok the meaning of "interface".
|