Bug 201072

Summary: [ews] Add EWS queue for applying watchlist
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, ews-watchlist, jbedard, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=201071
https://bugs.webkit.org/show_bug.cgi?id=201081
Attachments:
Description Flags
Patch
none
Patch
none
Patch jbedard: review+

Aakash Jain
Reported 2019-08-23 04:11:36 PDT
Applying watchlist feature was hidden inside Style queue in old EWS. This feature is independent of style checker and there is no specific reason it should be inside style queue. We should make a separate queue to apply watchlist.
Attachments
Patch (7.80 KB, patch)
2019-08-23 08:32 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch (8.33 KB, patch)
2019-08-23 11:46 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch (8.35 KB, patch)
2019-08-26 07:42 PDT, Aakash Jain 		jbedard: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-08-23 08:32:40 PDT
Created attachment 377128 [details] Patch
EWS Watchlist
Comment 2 2019-08-23 11:06:02 PDT Comment hidden (obsolete)
Aakash Jain
Comment 3 2019-08-23 11:08:48 PDT
Sample run: https://ews-build.webkit-uat.org/#/builders/43/builds/31
Aakash Jain
Comment 4 2019-08-23 11:46:50 PDT
Created attachment 377143 [details] Patch
EWS Watchlist
Comment 5 2019-08-23 11:50:35 PDT Comment hidden (obsolete)
Jonathan Bedard
Comment 6 2019-08-23 13:26:05 PDT
(In reply to Aakash Jain from comment #3) > Sample run: https://ews-build.webkit-uat.org/#/builders/43/builds/31 In this test run, it didn't list anyone to be added to the CC list...why is that?
Aakash Jain
Comment 7 2019-08-26 07:42:53 PDT
Created attachment 377244 [details] Patch
EWS Watchlist
Comment 8 2019-08-26 07:44:02 PDT Comment hidden (obsolete)
Aakash Jain
Comment 9 2019-08-26 08:04:57 PDT
> In this test run, it didn't list anyone to be added to the CC list...why is that? In that particular case, it was because the files modified in the patch weren't matching with any watchlist rules. However, in further testing, I found out that simply using the WatchList command wouldn't work without first applying the content of the patch to local directory. Updated the patch for that. Sample run: https://ews-build.webkit-uat.org/#/builders/43/builds/98
Aakash Jain
Comment 10 2019-08-26 08:13:52 PDT
Another one (with webkit-misc bot): https://ews-build.webkit-uat.org/#/builders/43/builds/107
Jonathan Bedard
Comment 11 2019-08-26 09:18:27 PDT
(In reply to Aakash Jain from comment #9) > > In this test run, it didn't list anyone to be added to the CC list...why is that? > In that particular case, it was because the files modified in the patch > weren't matching with any watchlist rules. However, in further testing, I > found out that simply using the WatchList command wouldn't work without > first applying the content of the patch to local directory. > > Updated the patch for that. Sample run: > https://ews-build.webkit-uat.org/#/builders/43/builds/98 That example logged in with your credentials, which seems wrong for production. Actually, I'm a little unclear why it needs to log in at all.
Aakash Jain
Comment 12 2019-08-26 09:27:26 PDT
> That example logged in with your credentials, which seems wrong for production. Please see https://bugs.webkit.org/show_bug.cgi?id=201072#c10 for another example. > > Actually, I'm a little unclear why it needs to log in at all. Because the cc list on bugzilla bug needs to be modified, which needs authentication.
Jonathan Bedard
Comment 13 2019-08-26 09:30:13 PDT
(In reply to Aakash Jain from comment #12) > > That example logged in with your credentials, which seems wrong for production. > Please see https://bugs.webkit.org/show_bug.cgi?id=201072#c10 for another > example. > > > > Actually, I'm a little unclear why it needs to log in at all. > Because the cc list on bugzilla bug needs to be modified, which needs > authentication. Ok, that makes sense, and I suppose we have ews@webkit.org for this exact purpose.
Aakash Jain
Comment 14 2019-08-26 10:08:25 PDT
Committed r249100: <https://trac.webkit.org/changeset/249100>
Radar WebKit Bug Importer
Comment 15 2019-08-26 10:09:22 PDT
<rdar://problem/54711226>
Note You need to log in before you can comment on or make changes to this bug.