Bug 201062

Summary: VirtualRegister::dump() can use more informative CallFrame header slot names.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. tzagallo: review+

Mark Lam
Reported 2019-08-22 18:38:00 PDT
For example, it currently dumps head3 instead of callee.
Attachments
proposed patch. (2.59 KB, patch)
2019-08-22 18:49 PDT, Mark Lam 		tzagallo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2019-08-22 18:49:16 PDT
Created attachment 377088 [details] proposed patch.
Tadeu Zagallo
Comment 2 2019-08-23 09:48:53 PDT
Comment on attachment 377088 [details] proposed patch. r=me
Tadeu Zagallo
Comment 3 2019-08-23 09:50:02 PDT
Comment on attachment 377088 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=377088&action=review > Source/JavaScriptCore/ChangeLog:3 > + VirtualRegister::dump() can be use more informative CallFrame header slot names. typo: s/can be use/can use/
Mark Lam
Comment 4 2019-08-23 10:27:28 PDT
Thanks for the review. Landed in r249052: <http://trac.webkit.org/r249052>.
Radar WebKit Bug Importer
Comment 5 2019-08-23 10:28:18 PDT
<rdar://problem/54645167>
Saam Barati
Comment 6 2019-08-23 11:06:08 PDT
Comment on attachment 377088 [details] proposed patch. Nice
Note You need to log in before you can comment on or make changes to this bug.