Bug 201062

Summary: VirtualRegister::dump() can use more informative CallFrame header slot names.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. tzagallo: review+

Description Mark Lam 2019-08-22 18:38:00 PDT 
For example, it currently dumps head3 instead of callee.
Comment 1 Mark Lam 2019-08-22 18:49:16 PDT 
Created attachment 377088 [details]
proposed patch.
Comment 2 Tadeu Zagallo 2019-08-23 09:48:53 PDT 
Comment on attachment 377088 [details]
proposed patch.

r=me
Comment 3 Tadeu Zagallo 2019-08-23 09:50:02 PDT 
Comment on attachment 377088 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=377088&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        VirtualRegister::dump() can be use more informative CallFrame header slot names.

typo: s/can be use/can use/
Comment 4 Mark Lam 2019-08-23 10:27:28 PDT 
Thanks for the review.  Landed in r249052: <http://trac.webkit.org/r249052>.
Comment 5 Radar WebKit Bug Importer 2019-08-23 10:28:18 PDT 
<rdar://problem/54645167>
Comment 6 Saam Barati 2019-08-23 11:06:08 PDT 
Comment on attachment 377088 [details]
proposed patch.

Nice