Bug 201049

Summary: [Subpixel layout] reddit.com comments are slightly scrollable
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: NEW ---    
Severity: Normal CC: bfulgham, ews-watchlist, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
simon.fraser: review+
Archive of layout-test-results from ews215 for win-future none

Description zalan 2019-08-22 13:08:38 PDT
<rdar://problem/49951104>
Comment 1 zalan 2019-08-22 13:19:13 PDT
Created attachment 377037 [details]
Patch
Comment 2 zalan 2019-08-22 13:23:46 PDT
Created attachment 377038 [details]
Patch
Comment 3 Simon Fraser (smfr) 2019-08-22 13:38:11 PDT
Comment on attachment 377038 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377038&action=review

> Source/WebCore/ChangeLog:9
> +        Since RootLines are forced to be on integral positions, we need to ensure that the block container's height is adjusted accordingly (to always enclose the lines in the case of LayoutUnit -> int conversion).  

Need more explanation here.
Comment 4 EWS Watchlist 2019-08-22 14:59:15 PDT
Comment on attachment 377038 [details]
Patch

Attachment 377038 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12957981

Number of test failures exceeded the failure limit.
Comment 5 EWS Watchlist 2019-08-22 14:59:17 PDT
Created attachment 377057 [details]
Archive of layout-test-results from ews215 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews215  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 6 zalan 2019-08-22 14:59:54 PDT
(In reply to Build Bot from comment #5)
> Created attachment 377057 [details]
> Archive of layout-test-results from ews215 for win-future
> 
> The attached test failures were seen while running run-webkit-tests on the
> win-ews.
> Bot: ews215  Port: win-future  Platform:
> CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
ofc.