Bug 201047

Summary: [watchOS] Disable Content Filtering in the simulator build
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, keith_miller, mark.lam, msaboff, saam, thorton, tzagallo, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 212711    
Attachments:
Description Flags
Patch none

Andy Estes
Reported 2019-08-22 12:11:35 PDT
[watchOS] Disable Content Filtering in the simulator build
Attachments
Patch (9.83 KB, patch)
2019-08-22 12:13 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2019-08-22 12:13:04 PDT
Created attachment 377033 [details] Patch
EWS Watchlist
Comment 2 2019-08-22 12:15:36 PDT
Attachment 377033 [details] did not pass style-queue: ERROR: Source/WTF/wtf/Platform.h:1092: CPP comments are not allowed in Platform.h, please use C comments /* ... */ [build/cpp_comment] [5] ERROR: Source/WTF/wtf/Platform.h:1092: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/Platform.h:1092: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 3 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3 2019-08-22 13:00:36 PDT
Comment on attachment 377033 [details] Patch Please fix the stylebot comments so you don't destroy everything.
Andy Estes
Comment 4 2019-08-22 13:03:19 PDT
(In reply to Tim Horton from comment #3) > Comment on attachment 377033 [details] > Patch > > Please fix the stylebot comments so you don't destroy everything. I think they're bogus because of the "//" in the radar URL, but I'll double check.
Tim Horton
Comment 5 2019-08-22 13:11:42 PDT
Oh I think you're right
Alexey Proskuryakov
Comment 6 2019-08-22 14:01:49 PDT
Is this something that would break regression tests? Asking because tests are running fine on the platform in question.
Andy Estes
Comment 7 2019-08-22 14:25:03 PDT
(In reply to Alexey Proskuryakov from comment #6) > Is this something that would break regression tests? Asking because tests > are running fine on the platform in question. It would not break regression tests, because they use a mock content filter that does not load WCA.framework.
Andy Estes
Comment 8 2019-08-22 15:08:33 PDT
... and file: URLs never trigger content filtering, and contentfiltering/ and http/ tests are skipped on this platform.
WebKit Commit Bot
Comment 9 2019-08-22 16:55:06 PDT
Comment on attachment 377033 [details] Patch Clearing flags on attachment: 377033 Committed r249036: <https://trac.webkit.org/changeset/249036>
WebKit Commit Bot
Comment 10 2019-08-22 16:55:07 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2019-08-22 16:56:18 PDT
<rdar://problem/54621024>
Note You need to log in before you can comment on or make changes to this bug.