Summary: | webkit-patch upload: Don't crash on large changes | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Darpinian <jdarpinian> | ||||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED CONFIGURATION CHANGED | ||||||||||
Severity: | Normal | CC: | ap, bfulgham, dino, kkinnunen | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=198948 | ||||||||||
Attachments: |
|
Description
James Darpinian
2019-08-22 11:22:36 PDT
Created attachment 377029 [details]
Patch
Created attachment 377030 [details]
Patch
Hey Dean, I ran into this while updating ANGLE, which produces large patches. Can you take a look? Comment on attachment 377030 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377030&action=review > Tools/ChangeLog:8 > + webkit-patch upload fails on large changes (~2000 files) because the prepare-ChangeLog step tries to > + execute a command line that is too long. This change allows webkit-patch upload to continue past > + the failure. Could you please elaborate on why it's acceptable to continue past this failure? Seems like we should make a decision for how many files we want to put into ChangeLog (too many is impractical), but that's a check that would be made at a different level in the code. Created attachment 377068 [details]
Patch
I updated the patch to fix the failure by splitting the command line, instead of ignoring the failure. PTAL The patch touches prepare-Changelog and its SVN parts. Changelogs are not used anymore. SVN is not used anymore. Currently it's hard to reproduce the solved issue since there's no test infra for prepare-ChangeLog and the patch doesn't add a test. Currently we haven't seen issues updating ANGLE. The prepare-ChangeLog might be still used and it might have the same issue if a git patch has too many files changed. However, since this patch hasn't received review in 3 years and we haven't seen the issues, maybe it's ok to re-solve this issue when it resurfaces. |