Bug 200999

Summary: [Mail] Tapping top of message scrolls back to copied text instead of top of the message
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, megan_gardner, webkit-bot-watchers-bugzilla, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Tim Horton 2019-08-21 15:17:36 PDT 
[Mail] Tapping top of message scrolls back to copied text instead of top of the message
Comment 1 Tim Horton 2019-08-21 15:18:07 PDT 
Created attachment 376928 [details]
Patch
Comment 2 Tim Horton 2019-08-21 15:18:08 PDT 
<rdar://problem/54564878>
Comment 3 Tim Horton 2019-08-21 15:21:46 PDT 
Created attachment 376929 [details]
Patch
Comment 4 Wenson Hsieh 2019-08-21 15:36:20 PDT 
Comment on attachment 376929 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376929&action=review

> LayoutTests/editing/selection/ios/change-selection-by-tapping-with-existing-selection.html:51
> +    // await UIHelper.activateElementAndWaitForInputSession(document.getElementById("editor"));

🤷🏻‍♂️
Comment 5 Tim Horton 2019-08-21 15:40:34 PDT 
(In reply to Wenson Hsieh from comment #4)
> Comment on attachment 376929 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=376929&action=review
> 
> > LayoutTests/editing/selection/ios/change-selection-by-tapping-with-existing-selection.html:51
> > +    // await UIHelper.activateElementAndWaitForInputSession(document.getElementById("editor"));
> 
> 🤷🏻‍♂️

LOL from the test I copied. Will remove
Comment 6 Tim Horton 2019-08-21 15:42:01 PDT 
Created attachment 376938 [details]
Patch
Comment 7 WebKit Commit Bot 2019-08-21 16:05:33 PDT 
Comment on attachment 376938 [details]
Patch

Clearing flags on attachment: 376938

Committed r248974: <https://trac.webkit.org/changeset/248974>
Comment 8 WebKit Commit Bot 2019-08-21 16:05:35 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Ryan Haddad 2019-08-22 09:37:50 PDT 
This change caused the following tests to fail on iOS Simulator:
editing/deleting/smart-delete-003.html
editing/deleting/smart-delete-004.html
editing/pasteboard/smart-paste-008.html

https://build.webkit.org/results/Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/r249004%20(5907)/results.html
Comment 10 Tim Horton 2019-08-22 10:36:06 PDT 
(In reply to Ryan Haddad from comment #9)
> This change caused the following tests to fail on iOS Simulator:
> editing/deleting/smart-delete-003.html
> editing/deleting/smart-delete-004.html
> editing/pasteboard/smart-paste-008.html
> 
> https://build.webkit.org/results/
> Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/r249004%20(5907)/
> results.html

Rebaselined in https://trac.webkit.org/changeset/249017/webkit