Bug 200998 – [results.webkit.org Webkit.css] Change input's disable style

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Zhifei Fang]

I am using required and :vaild to detect if an input have value or not, but this will not work for disabled input, therefore, I change the disable style to assume they already have a value to avoid the label and input text overlay.

Long term solution here is I should make a input component, it will using js to detect if it has value already, and the user can use it more flexible. For now, all the input have the required attribute, this is ok for those send from directly through XHR, but not ok for those who have optional element in a form and submit the form via form action.

[Zhifei Fang]

Created attachment 376922 [details]
Patch

[Jonathan Bedard]

Comment on attachment 376922 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376922&action=review

> Tools/resultsdbpy/resultsdbpy/view/static/library/css/index.html:1570
> +    <label>Disabled with existing value</label>

Doesn't really work in light mode.

[Zhifei Fang]

Created attachment 376925 [details]
Patch

[Jonathan Bedard]

Comment on attachment 376925 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376925&action=review

> Tools/ChangeLog:11
> +        * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:

Can we make this changelog meaningful? Seems like the template prepare-changelog laid down is mostly meaningful.

[Zhifei Fang]

Created attachment 376930 [details]
Patch

[Jonathan Bedard]

Comment on attachment 376930 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376930&action=review

> Tools/ChangeLog:9
> +        * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: Adding a new example for disabled input that already have a value

'Adding a new example for disabled input that already has a value.'

> Tools/ChangeLog:13
> +        (.input>input[type="text"][required][disabled],.input>input[type="number"][required][disabled],):When disable, we set the style always like the one have value

'When disabling a text input element without a value, the style should match the style of a text input element with a value'

[Zhifei Fang]

Created attachment 376937 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 376937 [details]
Patch

Clearing flags on attachment: 376937

Committed r249021: <https://trac.webkit.org/changeset/249021>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/54608040>