Summary: | Adopt AVSystemController_ActiveAudioRouteDidChangeNotification | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||
Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, eric.carlson, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Jer Noble
2019-08-21 12:52:45 PDT
Created attachment 376907 [details]
Patch
Comment on attachment 376907 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376907&action=review > Source/WebCore/Modules/mediastream/MediaStream.h:162 > + bool shouldOverridePauseDuringRouteChanges() const { return true; } Nit: I think it would be more logical to flip the question to ask what the class *should* do, something like "bool shouldPauseOnRouteChange()" (In reply to Eric Carlson from comment #3) > Comment on attachment 376907 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=376907&action=review > > > Source/WebCore/Modules/mediastream/MediaStream.h:162 > > + bool shouldOverridePauseDuringRouteChanges() const { return true; } > > Nit: I think it would be more logical to flip the question to ask what the > class *should* do, something like "bool shouldPauseOnRouteChange()" I had that originally, but wanted the method to be explicit that we were overriding the system's instructions to pause on route changes. I will, however, make it Change() not Changes(). Created attachment 376915 [details]
Patch for landing
Comment on attachment 376915 [details] Patch for landing Clearing flags on attachment: 376915 Committed r248962: <https://trac.webkit.org/changeset/248962> All reviewed patches have been landed. Closing bug. Reopening to attach new patch. Created attachment 376943 [details]
Follow up Patch
Comment on attachment 376943 [details] Follow up Patch Clearing flags on attachment: 376943 Committed r248978: <https://trac.webkit.org/changeset/248978> All reviewed patches have been landed. Closing bug. Follow-up build fix: Committed r248997: <https://trac.webkit.org/changeset/248997> |