Bug 200985

Summary: registrableDomainsToRemoveWebsiteDataFor() does not need to return a HashMap
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, bfulgham, cmarcelo, commit-queue, dbates, ews-watchlist, ggaren, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2019-08-21 10:32:21 PDT
registrableDomainsToRemoveWebsiteDataFor() does not need to return a HashMap. It is more efficient to simply return a Vector since we never need to look up keys.
Attachments
Patch (22.49 KB, patch)
2019-08-21 10:33 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-08-21 10:33:20 PDT
Created attachment 376892 [details] Patch
John Wilander
Comment 2 2019-08-21 10:49:14 PDT
Comment on attachment 376892 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376892&action=review I believe this has the side effect of allowing multiple entries for the same RegistrableDomain. That should be fine though, since even if we were to introduce such a bug, we would still delete the right data. > Source/WTF/wtf/CrossThreadCopier.h:156 > + Nice!
Chris Dumez
Comment 3 2019-08-21 11:41:17 PDT
Comment on attachment 376892 [details] Patch The Vector is populated from HashMaps of RegistrableDomains, I therefore do not think we can have duplicate RegistrableDomains in the Vector right now.
WebKit Commit Bot
Comment 4 2019-08-21 12:24:40 PDT
Comment on attachment 376892 [details] Patch Clearing flags on attachment: 376892 Committed r248956: <https://trac.webkit.org/changeset/248956>
WebKit Commit Bot
Comment 5 2019-08-21 12:24:41 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-08-21 12:25:18 PDT
<rdar://problem/54566740>
Note You need to log in before you can comment on or make changes to this bug.