Summary: | [geolocation] Rename interfaces and remove [NoInterfaceObject] | ||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anssi Kostiainen <anssi.kostiainen> | ||||||||||||||||||||
Component: | New Bugs | Assignee: | Chris Dumez <cdumez> | ||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||
Severity: | Normal | CC: | achristensen, anssi.kostiainen, benjamin, cdumez, commit-queue, esprehn+autocc, ews-watchlist, ggaren, kondapallykalyan, rniwa, webkit-bug-importer, youennf | ||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||
Attachments: |
|
Description
Anssi Kostiainen
2019-08-19 06:16:39 PDT
Also: Add [Exposed=Window] to these three interfaces: https://github.com/w3c/geolocation-api/pull/32 Created attachment 377067 [details]
WIP Patch
Attachment 377067 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
Total errors found: 3 in 42 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 377069 [details]
WIP Patch
Attachment 377069 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
Total errors found: 3 in 46 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 377070 [details]
WIP Patch
Attachment 377070 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
Total errors found: 3 in 47 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 377072 [details]
WIP Patch
Attachment 377072 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
Total errors found: 3 in 47 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 377076 [details]
Patch
Created attachment 377077 [details]
Patch
Attachment 377077 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
Total errors found: 3 in 60 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 377132 [details]
Patch
Attachment 377132 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebKit/UIProcess/API/glib/WebKitGeolocationManager.cpp:73: _WebKitGeolocationPosition is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebKit/UIProcess/API/glib/WebKitGeolocationManager.cpp:78: _WebKitGeolocationPosition is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
Total errors found: 5 in 66 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 377135 [details]
Patch
Attachment 377135 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebKit/UIProcess/API/glib/WebKitGeolocationManager.cpp:73: _WebKitGeolocationPosition is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebKit/UIProcess/API/glib/WebKitGeolocationManager.cpp:78: _WebKitGeolocationPosition is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
Total errors found: 5 in 66 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 377142 [details]
Patch
Attachment 377142 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebKit/UIProcess/API/glib/WebKitGeolocationManager.cpp:73: _WebKitGeolocationPosition is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebKit/UIProcess/API/glib/WebKitGeolocationManager.cpp:78: _WebKitGeolocationPosition is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
Total errors found: 5 in 66 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 377142 [details] Patch Clearing flags on attachment: 377142 Committed r249066: <https://trac.webkit.org/changeset/249066> All reviewed patches have been landed. Closing bug. |