Bug 200885

Summary:

[geolocation] Rename interfaces and remove [NoInterfaceObject]

Product:

WebKit

Reporter:

Anssi Kostiainen <anssi.kostiainen>

Component:

New Bugs

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, anssi.kostiainen, benjamin, cdumez, commit-queue, esprehn+autocc, ews-watchlist, ggaren, kondapallykalyan, rniwa, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Anssi Kostiainen

Reported 2019-08-19 06:16:39 PDT

The Geolocation API specification renamed the following interfaces and removed the [NoInterfaceObject] annotation so that these types are now exposed to script: Coordinates -> GeolocationCoordinates Position -> GeolocationPosition PositionError -> GeolocationPositionError This is done in response to an effort to remove the [NoInterfaceObject] annotation from WebIDL. Spec pull requests (merged): https://github.com/w3c/geolocation-api/pull/20 https://github.com/w3c/geolocation-api/pull/23 Chromium CL: https://chromium-review.googlesource.com/c/chromium/src/+/1471230

Attachments
WIP Patch (80.56 KB, patch) 2019-08-22 16:18 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (83.92 KB, patch) 2019-08-22 16:25 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (84.88 KB, patch) 2019-08-22 16:27 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (84.85 KB, patch) 2019-08-22 16:30 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (127.29 KB, patch) 2019-08-22 16:55 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (127.99 KB, patch) 2019-08-22 16:57 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (135.46 KB, patch) 2019-08-23 10:26 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (135.57 KB, patch) 2019-08-23 10:53 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (135.32 KB, patch) 2019-08-23 11:46 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Anssi Kostiainen

Comment 1 2019-08-22 03:33:03 PDT

Also: Add [Exposed=Window] to these three interfaces: https://github.com/w3c/geolocation-api/pull/32

Chris Dumez

Comment 2 2019-08-22 16:18:28 PDT

Created attachment 377067 [details] WIP Patch

EWS Watchlist

Comment 3 2019-08-22 16:20:13 PDT

Attachment 377067 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 3 in 42 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 4 2019-08-22 16:25:49 PDT

Created attachment 377069 [details] WIP Patch

EWS Watchlist

Comment 5 2019-08-22 16:27:23 PDT

Attachment 377069 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 3 in 46 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 6 2019-08-22 16:27:59 PDT

Created attachment 377070 [details] WIP Patch

EWS Watchlist

Comment 7 2019-08-22 16:30:51 PDT

Attachment 377070 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 3 in 47 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 8 2019-08-22 16:30:52 PDT

Created attachment 377072 [details] WIP Patch

EWS Watchlist

Comment 9 2019-08-22 16:33:07 PDT

Attachment 377072 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 3 in 47 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 10 2019-08-22 16:55:26 PDT

Created attachment 377076 [details] Patch

Chris Dumez

Comment 11 2019-08-22 16:57:44 PDT

Created attachment 377077 [details] Patch

EWS Watchlist

Comment 12 2019-08-22 17:57:39 PDT

Attachment 377077 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 3 in 60 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 13 2019-08-23 10:26:38 PDT

Created attachment 377132 [details] Patch

EWS Watchlist

Comment 14 2019-08-23 10:28:24 PDT

Attachment 377132 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebKit/UIProcess/API/glib/WebKitGeolocationManager.cpp:73: _WebKitGeolocationPosition is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/UIProcess/API/glib/WebKitGeolocationManager.cpp:78: _WebKitGeolocationPosition is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 5 in 66 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 15 2019-08-23 10:53:19 PDT

Created attachment 377135 [details] Patch

EWS Watchlist

Comment 16 2019-08-23 10:54:59 PDT

Attachment 377135 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebKit/UIProcess/API/glib/WebKitGeolocationManager.cpp:73: _WebKitGeolocationPosition is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/UIProcess/API/glib/WebKitGeolocationManager.cpp:78: _WebKitGeolocationPosition is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 5 in 66 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 17 2019-08-23 11:46:37 PDT

Created attachment 377142 [details] Patch

EWS Watchlist

Comment 18 2019-08-23 11:49:35 PDT

Attachment 377142 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/geolocation/GeolocationPositionError.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebKit/UIProcess/API/glib/WebKitGeolocationManager.cpp:73: _WebKitGeolocationPosition is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/UIProcess/API/glib/WebKitGeolocationManager.cpp:78: _WebKitGeolocationPosition is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 5 in 66 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 19 2019-08-23 13:59:36 PDT

Comment on attachment 377142 [details] Patch Clearing flags on attachment: 377142 Committed r249066: <https://trac.webkit.org/changeset/249066>

WebKit Commit Bot

Comment 20 2019-08-23 14:00:11 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 21 2019-08-23 14:02:30 PDT

<rdar://problem/54653181>

Note You need to log in before you can comment on or make changes to this bug.