REGRESSION (r248772) Many WebGL tests are timing out due to changes in iFrame behavior

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Russell Epstein]

Created attachment 376566 [details]
List of WebGL Tests that are Timing Out

The following layout tests are failing as of https://trac.webkit.org/changeset/248772/webkit :

webgl/2.0.0/conformance/attribs/gl-matrix-attributes.html
webgl/2.0.0/conformance2/attribs/gl-vertex-attrib.html
webgl/2.0.0/conformance2/rendering/blitframebuffer-filter-outofbounds.html
webgl/2.0.0/conformance2/rendering/blitframebuffer-outside-readbuffer.html
webgl/2.0.0/conformance2/rendering/blitframebuffer-srgb-and-linear-drawbuffers.html
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-r11f_g11f_b10f-rgb-float.html
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-r11f_g11f_b10f-rgb-unsigned_int_10f_11f_11f_rev.html
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-r16f-red-half_float.html
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-r8-red-unsigned_byte.html
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rg16f-rg-float.html
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rg32f-rg-float.html
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rg8-rg-unsigned_byte.html
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rgb16f-rgb-half_float.html
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rgb565-rgb-unsigned_byte.html
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rgb5_a1-rgba-unsigned_short_5_5_5_1.html
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rgb8ui-rgb_integer-unsigned_byte.html
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rgb9_e5-rgb-half_float.html
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rgba16f-rgba-float.html
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rgba32f-rgba-float.html
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rgba4-rgba-unsigned_byte.html
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rgba8-rgba-unsigned_byte.html
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-srgb8_alpha8-rgba-unsigned_byte.html
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-r11f_g11f_b10f-rgb-float.html
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-r11f_g11f_b10f-rgb-unsigned_int_10f_11f_11f_rev.html
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgb16f-rgb-float.html
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgb32f-rgb-float.html
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgb565-rgb-unsigned_short_5_6_5.html
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgb5_a1-rgba-unsigned_byte.html
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgb8-rgb-unsigned_byte.html
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgb9_e5-rgb-float.html
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgba16f-rgba-half_float.html
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgba4-rgba-unsigned_short_4_4_4_4.html
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-rgba8ui-rgba_integer-unsigned_byte.html
webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-3d-srgb8-rgb-unsigned_byte.html

Steps to Reproduce:

Confirmed issue occurs on r248772 but not r248771 with the following command:

run-webkit-tests --ios-simulator --no-retry --no-sample-on-timeout --test-list testlist

Test History:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#tests=webgl%2F2.0.0%2Fconformance%2Fattribs%2Fgl-matrix-attributes.html%20webgl%2F2.0.0%2Fconformance2%2Fattribs%2Fgl-vertex-attrib.html%20webgl%2F2.0.0%2Fconformance2%2Frendering%2Fblitframebuffer-filter-outofbounds.html%20webgl%2F2.0.0%2Fconformance2%2Frendering%2Fblitframebuffer-outside-readbuffer.html%20webgl%2F2.0.0%2Fconformance2%2Frendering%2Fblitframebuffer-srgb-and-linear-drawbuffers.html%20webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fcanvas_sub_rectangle%2Ftex-2d-r11f_g11f_b10f-rgb-float.html%20webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fcanvas_sub_rectangle%2Ftex-2d-r11f_g11f_b10f-rgb-unsigned_int_10f_11f_11f_rev.html%20webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fcanvas_sub_rectangle%2Ftex-2d-r16f-red-half_float.html%20webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fcanvas_sub_rectangle%2Ftex-2d-r8-red-unsigned_byte.html%20webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fcanvas_sub_rectangle%2Ftex-2d-rg16f-rg-float.html%20webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fcanvas_sub_rectangle%2Ftex-2d-rg32f-rg-float.html%20webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fcanvas_sub_rectangle%2Ftex-2d-rg8-rg-unsigned_byte.html%20webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fcanvas_sub_rectangle%2Ftex-2d-rgb16f-rgb-half_float.html%20webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fcanvas_sub_rectangle%2Ftex-2d-rgb565-rgb-unsigned_byte.html%20webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fcanvas_sub_rectangle%2Ftex-2d-rgb5_a1-rgba-unsigned_short_5_5_5_1.html%20webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fcanvas_sub_rectangle%2Ftex-2d-rgb8ui-rgb_integer-unsigned_byte.html%20webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fcanvas_sub_rectangle%2Ftex-2d-rgb9_e5-rgb-half_float.html%20webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fcanvas_sub_rectangle%2Ftex-2d-rgba16f-rgba-float.html%20webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fcanvas_sub_rectangle%2Ftex-2d-rgba32f-rgba-float.html%20webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fcanvas_sub_rectangle%2Ftex-2d-rgba4-rgba-unsigned_byte.html%20webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fcanvas_sub_rectangle%2Ftex-2d-rgba8-rgba-unsigned_byte.html%20webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fcanvas_sub_rectangle%2Ftex-2d-srgb8_alpha8-rgba-unsigned_byte.html%20webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fcanvas_sub_rectangle%2Ftex-3d-r11f_g11f_b10f-rgb-float.html%20webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fcanvas_sub_rectangle%2Ftex-3d-r11f_g11f_b10f-rgb-unsigned_int_10f_11f_11f_rev.html%20webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fcanvas_sub_rectangle%2Ftex-3d-rgb16f-rgb-float.html%20webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fcanvas_sub_rectangle%2Ftex-3d-rgb32f-rgb-float.html%20webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fcanvas_sub_rectangle%2Ftex-3d-rgb565-rgb-unsigned_short_5_6_5.html%20webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fcanvas_sub_rectangle%2Ftex-3d-rgb5_a1-rgba-unsigned_byte.html%20webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fcanvas_sub_rectangle%2Ftex-3d-rgb8-rgb-unsigned_byte.html%20webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fcanvas_sub_rectangle%2Ftex-3d-rgb9_e5-rgb-float.html%20webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fcanvas_sub_rectangle%2Ftex-3d-rgba16f-rgba-half_float.html%20webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fcanvas_sub_rectangle%2Ftex-3d-rgba4-rgba-unsigned_short_4_4_4_4.html%20webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fcanvas_sub_rectangle%2Ftex-3d-rgba8ui-rgba_integer-unsigned_byte.html%20webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fcanvas_sub_rectangle%2Ftex-3d-srgb8-rgb-unsigned_byte.html

Sample Diff:

--- /Volumes/Data/slave/ios-simulator-12-debug-tests-wk2/build/layout-test-results/webgl/2.0.0/conformance/attribs/gl-matrix-attributes-expected.txt
+++ /Volumes/Data/slave/ios-simulator-12-debug-tests-wk2/build/layout-test-results/webgl/2.0.0/conformance/attribs/gl-matrix-attributes-actual.txt
@@ -1,5 +1,3 @@
-This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
+#PID UNRESPONSIVE - WebKitTestRunnerApp (pid 89239)
+FAIL: Timed out waiting for notifyDone to be called
 
-Test: ../../resources/webgl_test_files/conformance/attribs/gl-matrix-attributes.html
-[ PASS ] All tests passed
-

[Radar WebKit Bug Importer]

<rdar://problem/54412986>

[Antti Koivisto]

rolled out r248772 in https://trac.webkit.org/r248816