The default tab index of output and fieldset should be -1

• Component: DOM
• Status: RESOLVED FIXED

[Ryosuke Niwa]

According to the latest HTML specification, the default tab index of output, fieldset, and keygen should be -1.
This is also the behavior of Chrome & Firefox.

[Ryosuke Niwa]

https://html.spec.whatwg.org/multipage/interaction.html#the-tabindex-attribute

[Ryosuke Niwa]

Apparently keygen had been dropped from the standard and other browser have removed it.

[Ryosuke Niwa]

Created attachment 376568 [details]
Fixes the bug

[Alex Christensen]

Comment on attachment 376568 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=376568&action=review

> Source/WebCore/ChangeLog:35
> +        Test: fast/dom/tabindex-defaults.html

No web platform test?

> Source/WebCore/html/HTMLButtonElement.h:54
> +    int defaultTabIndex() const;

Should this be "override" or "final"?

> Source/WebCore/html/HTMLTextAreaElement.h:116
> +    int defaultTabIndex() const;

ditto.

[Ryosuke Niwa]

Comment on attachment 376568 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=376568&action=review

>> Source/WebCore/ChangeLog:35
>> +        Test: fast/dom/tabindex-defaults.html
> 
> No web platform test?

There is one test upstream but they don't test output and fieldset.

>> Source/WebCore/html/HTMLButtonElement.h:54
>> +    int defaultTabIndex() const;
> 
> Should this be "override" or "final"?

Yes. Fixed to be final.

>> Source/WebCore/html/HTMLTextAreaElement.h:116
>> +    int defaultTabIndex() const;
> 
> ditto.

Also fixed.

[Ryosuke Niwa]

Committed r248914: <https://trac.webkit.org/changeset/248914>

[Radar WebKit Bug Importer]

<rdar://problem/54524545>

[Ryan Haddad]

(In reply to Ryosuke Niwa from comment #6)
> Committed r248914: <https://trac.webkit.org/changeset/248914>

imported/w3c/web-platform-tests/html/infrastructure/common-dom-interfaces/collections/htmlformcontrolscollection.html is failing after this change

--- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/html/infrastructure/common-dom-interfaces/collections/htmlformcontrolscollection-expected.txt
+++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/html/infrastructure/common-dom-interfaces/collections/htmlformcontrolscollection-actual.txt
@@ -1,5 +1,5 @@
 
-PASS The length attribute must return the number of elements in the form 
+FAIL The length attribute must return the number of elements in the form assert_equals: The length attribute is incorrect. expected 1 but got 2
 PASS HTMLFormControlsCollection.item(index) must return the indexed item 
 PASS HTMLFormControlsCollection[index] must return the indexed item 
 PASS HTMLFormControlsCollection is not callable 
@@ -10,6 +10,7 @@
 PASS The namedItem(name) must return null if the name is empty 
 PASS The namedItem(name) must return null if there is no matched element 
 PASS Controls can be indexed by id or name attribute 
+FAIL Keygen controls do not show up at all assert_equals: Keygen does not show up when queried by id. expected null but got Element node <keygen id="kg" name="key"></keygen>
 PASS The namedItem(name) must return the items with id or name attribute 
 PASS The HTMLFormControlsCollection interface is used for collections of listed elements in form element 
 PASS The HTMLFormControlsCollection interface is used for collections of listed elements in fieldset element

[Ryosuke Niwa]

(In reply to Ryan Haddad from comment #8)
> (In reply to Ryosuke Niwa from comment #6)
> > Committed r248914: <https://trac.webkit.org/changeset/248914>
> 
> imported/w3c/web-platform-tests/html/infrastructure/common-dom-interfaces/
> collections/htmlformcontrolscollection.html is failing after this change
> 
> ---
> /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/
> imported/w3c/web-platform-tests/html/infrastructure/common-dom-interfaces/
> collections/htmlformcontrolscollection-expected.txt
> +++
> /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/
> imported/w3c/web-platform-tests/html/infrastructure/common-dom-interfaces/
> collections/htmlformcontrolscollection-actual.txt
> @@ -1,5 +1,5 @@
>  
> -PASS The length attribute must return the number of elements in the form 
> +FAIL The length attribute must return the number of elements in the form
> assert_equals: The length attribute is incorrect. expected 1 but got 2
>  PASS HTMLFormControlsCollection.item(index) must return the indexed item 
>  PASS HTMLFormControlsCollection[index] must return the indexed item 
>  PASS HTMLFormControlsCollection is not callable 
> @@ -10,6 +10,7 @@
>  PASS The namedItem(name) must return null if the name is empty 
>  PASS The namedItem(name) must return null if there is no matched element 
>  PASS Controls can be indexed by id or name attribute 
> +FAIL Keygen controls do not show up at all assert_equals: Keygen does not
> show up when queried by id. expected null but got Element node <keygen
> id="kg" name="key"></keygen>
>  PASS The namedItem(name) must return the items with id or name attribute 
>  PASS The HTMLFormControlsCollection interface is used for collections of
> listed elements in form element 
>  PASS The HTMLFormControlsCollection interface is used for collections of
> listed elements in fieldset element

Ugh... my commit had a superfluous change to LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/common-dom-interfaces/collections/htmlformcontrolscollection.html. Reverting the test change now.

[Ryosuke Niwa]

Fixed in https://trac.webkit.org/changeset/248924.