Bug 200832

Summary: Drop StorageArea::setWorkQueue() member function
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, ggaren, sihui_liu, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2019-08-16 14:25:18 PDT
Drop StorageArea::setWorkQueue() member function and pass the WorkQueue to the StorageArea constructor instead. The WorkQueue can never get updated so an explicit setter is not necessary. It also makes it clearer that the m_queue data member can never be null.
Attachments
Patch (17.92 KB, patch)
2019-08-16 14:29 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (18.78 KB, patch)
2019-08-16 15:44 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (19.24 KB, patch)
2019-08-16 15:53 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-08-16 14:29:41 PDT
Created attachment 376542 [details] Patch
Chris Dumez
Comment 2 2019-08-16 15:44:26 PDT
Created attachment 376549 [details] Patch
Chris Dumez
Comment 3 2019-08-16 15:53:18 PDT
Created attachment 376552 [details] Patch
Alex Christensen
Comment 4 2019-08-16 17:33:35 PDT
Comment on attachment 376552 [details] Patch nice
WebKit Commit Bot
Comment 5 2019-08-16 18:06:13 PDT
Comment on attachment 376552 [details] Patch Clearing flags on attachment: 376552 Committed r248809: <https://trac.webkit.org/changeset/248809>
WebKit Commit Bot
Comment 6 2019-08-16 18:06:14 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-08-16 18:07:20 PDT
<rdar://problem/54415820>
Note You need to log in before you can comment on or make changes to this bug.