Bug 200826

Summary: Functions with no parameters in WebKit/Shared/API/c and WebKit/UIProcess/API/C are missing a "void" specifier in their argument list
Product: WebKit Reporter: Kate Cheney <katherine_cheney>
Component: WebKit APIAssignee: Kate Cheney <katherine_cheney>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, aestes, ap, cdumez, commit-queue, ddkilzer, fujii, thorton, webkit-bug-importer, wenson_hsieh, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Kate Cheney
Reported 2019-08-16 13:11:34 PDT
In a local build, I was receiving this compiler error as I was trying to fix another patch: "error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes]"
Attachments
Patch (31.77 KB, patch)
2019-08-16 13:18 PDT, Kate Cheney 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kate Cheney
Comment 1 2019-08-16 13:18:27 PDT
Created attachment 376527 [details] Patch
Chris Dumez
Comment 2 2019-08-16 13:21:28 PDT
Comment on attachment 376527 [details] Patch r=me assuming the bots are happy.
Tim Horton
Comment 3 2019-08-16 13:23:53 PDT
Weird, I thought we decided that this warning was too oppressive to turn on
WebKit Commit Bot
Comment 4 2019-08-16 14:13:47 PDT
Comment on attachment 376527 [details] Patch Clearing flags on attachment: 376527 Committed r248797: <https://trac.webkit.org/changeset/248797>
WebKit Commit Bot
Comment 5 2019-08-16 14:13:48 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-08-16 14:14:20 PDT
<rdar://problem/54406762>
Alexey Proskuryakov
Comment 7 2019-08-16 22:27:11 PDT
> Weird, I thought we decided that this warning was too oppressive to turn on I also feel like this was an intentional choice. On the other hand, declaring functions with () is pretty dangerous for pure C callers, so why would we do that while claiming C compatibility.
Note You need to log in before you can comment on or make changes to this bug.