Bug 200824

Summary: Web Inspector: Syntax Highlight more CSS media queries
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, hi, inspector-bugzilla-changes, joepeck, nvasilyev, simon.fraser, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[IMAGE] Before
none
[IMAGE] After
none
[PATCH] Proposed Fix
hi: review+
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2019-08-16 13:06:00 PDT
Syntax Highlight more CSS media queries Specifically if there is a `error` inside of an `atRule` we can detect a few and treat them like properties!
Attachments
[IMAGE] Before (2.04 MB, image/png)
2019-08-16 13:06 PDT, Joseph Pecoraro 		no flags
Details
[IMAGE] After (2.02 MB, image/png)
2019-08-16 13:06 PDT, Joseph Pecoraro 		no flags
Details
[PATCH] Proposed Fix (2.22 KB, patch)
2019-08-16 13:07 PDT, Joseph Pecoraro 		hi: review+
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (2.43 KB, patch)
2019-08-16 19:06 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2019-08-16 13:06:26 PDT
Created attachment 376522 [details] [IMAGE] Before
Joseph Pecoraro
Comment 2 2019-08-16 13:06:37 PDT
Created attachment 376523 [details] [IMAGE] After
Joseph Pecoraro
Comment 3 2019-08-16 13:07:41 PDT
Created attachment 376524 [details] [PATCH] Proposed Fix
Nikita Vasilyev
Comment 4 2019-08-16 13:24:36 PDT
This is great!
Devin Rousso
Comment 5 2019-08-16 14:24:40 PDT
Comment on attachment 376524 [details] [PATCH] Proposed Fix r=me, nice!
Joseph Pecoraro
Comment 6 2019-08-16 19:06:31 PDT
Created attachment 376576 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 7 2019-08-16 19:48:55 PDT
Comment on attachment 376576 [details] [PATCH] Proposed Fix Clearing flags on attachment: 376576 Committed r248810: <https://trac.webkit.org/changeset/248810>
Radar WebKit Bug Importer
Comment 8 2019-08-16 19:56:18 PDT
<rdar://problem/54418037>
Note You need to log in before you can comment on or make changes to this bug.