Bug 200806

Summary: Split tabIndex computation for DOM and the rest of WebCore
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: WebCore Misc.Assignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, ews-watchlist, simon.fraser, webkit-bug-importer, wenson_hsieh, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 199606    
Attachments:
Description Flags
Cleanup
none
Fixed GTK+ build none

Ryosuke Niwa
Reported 2019-08-15 20:42:46 PDT
Right now, a bunch of WebCore's internal functions make use of Element::tabIndex. This is problematic in order to resolve the bug 199606, in which we're trying to make tabIndex IDL attribute simply reflect tabIndex content attribute instead of it being dependent on focusability of the element. So split the code so that we have one function for computing the bindings value, and another for internal use of WebCore.
Attachments
Cleanup (19.38 KB, patch)
2019-08-15 21:06 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixed GTK+ build (21.15 KB, patch)
2019-08-15 23:13 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2019-08-15 21:06:23 PDT
Created attachment 376471 [details] Cleanup
EWS Watchlist
Comment 2 2019-08-15 21:07:50 PDT
Attachment 376471 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:17: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ryosuke Niwa
Comment 3 2019-08-15 23:13:29 PDT
Created attachment 376473 [details] Fixed GTK+ build
Chris Dumez
Comment 4 2019-08-16 12:35:42 PDT
Comment on attachment 376473 [details] Fixed GTK+ build r=me
Ryosuke Niwa
Comment 5 2019-08-16 12:40:28 PDT
Thanks for the review!
Ryosuke Niwa
Comment 6 2019-08-16 12:43:35 PDT
Comment on attachment 376473 [details] Fixed GTK+ build Clearing flags on attachment: 376473 Committed r248784: <https://trac.webkit.org/changeset/248784>
Ryosuke Niwa
Comment 7 2019-08-16 12:43:37 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-08-16 12:44:16 PDT
<rdar://problem/54403126>
Note You need to log in before you can comment on or make changes to this bug.