Bug 200753

Summary: [WHLSL] Add unary plus
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: WebGPUAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Needs tests
none
Patch
none
Patch none

Myles C. Maxfield
Reported 2019-08-14 19:49:39 PDT
...
Attachments
Needs tests (21.28 KB, patch)
2019-08-14 19:51 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (28.90 KB, patch)
2019-08-15 14:58 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (9.46 KB, patch)
2019-08-15 18:22 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2019-08-14 19:51:23 PDT
Created attachment 376345 [details] Needs tests
Myles C. Maxfield
Comment 3 2019-08-15 14:58:26 PDT
Created attachment 376425 [details] Patch
Saam Barati
Comment 4 2019-08-15 18:04:27 PDT
Comment on attachment 376425 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376425&action=review > LayoutTests/webgpu/whlsl/vector-addition-subtraction.html:1 > +<!DOCTYPE html> this is aa nice test. I'd put "matrix" in the name of the file too. > Source/WebCore/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt:34803 > +int3 operator+(int3 a) { > + return a; > +} I added everything already except unary plus. Let's make these native. They should "Just Work"
Myles C. Maxfield
Comment 5 2019-08-15 18:22:46 PDT
Created attachment 376461 [details] Patch
Saam Barati
Comment 6 2019-08-15 18:24:57 PDT
Comment on attachment 376461 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376461&action=review > Source/WebCore/ChangeLog:8 > + HLSL has these, so we should too. nit: "has these" => "has this"
Myles C. Maxfield
Comment 7 2019-08-15 18:25:44 PDT
Comment on attachment 376461 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376461&action=review >> Source/WebCore/ChangeLog:8 >> + HLSL has these, so we should too. > > nit: "has these" => "has this" They are multiple functions
WebKit Commit Bot
Comment 8 2019-08-15 18:54:26 PDT
Comment on attachment 376461 [details] Patch Clearing flags on attachment: 376461 Committed r248756: <https://trac.webkit.org/changeset/248756>
WebKit Commit Bot
Comment 9 2019-08-15 18:54:28 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2019-08-15 18:55:20 PDT
<rdar://problem/54373639>
Note You need to log in before you can comment on or make changes to this bug.