Bug 200720

Summary: Update .xcconfig symbols to reflect the current set of past and future product versions.
Product: WebKit Reporter: Keith Rollin <krollin>
Component: WebKit Misc.Assignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, cdumez, commit-queue, dino, eric.carlson, ews-watchlist, graouts, keith_miller, kondapallykalyan, mark.lam, msaboff, rniwa, saam, thorton, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=200694
https://bugs.webkit.org/show_bug.cgi?id=200937
https://bugs.webkit.org/show_bug.cgi?id=200963
Attachments:
Description Flags
Patch
none
Patch none

Keith Rollin
Reported 2019-08-14 09:34:01 PDT
Remove version symbols related to old OS's we no longer support, ensure that version symbols are defined for OS's we do support.
Attachments
Patch (51.53 KB, patch)
2019-08-14 09:37 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Patch (51.59 KB, patch)
2019-08-29 15:46 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-08-14 09:34:16 PDT
<rdar://problem/54305032>
Keith Rollin
Comment 2 2019-08-14 09:37:00 PDT
Created attachment 376273 [details] Patch
EWS Watchlist
Comment 3 2019-08-14 09:39:58 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Keith Rollin
Comment 4 2019-08-14 10:07:33 PDT
Comment on attachment 376273 [details] Patch I think I should hold off on this in order to make sure there are no more references to the symbols being removed. I'm not sure about those SINCE macros.
Keith Rollin
Comment 5 2019-08-14 10:08:55 PDT
Also, I think I can get rid of the symbols identifying 10.13.
Keith Rollin
Comment 6 2019-08-29 15:46:37 PDT
Created attachment 377638 [details] Patch
WebKit Commit Bot
Comment 7 2019-08-29 21:18:37 PDT
Comment on attachment 377638 [details] Patch Clearing flags on attachment: 377638 Committed r249312: <https://trac.webkit.org/changeset/249312>
WebKit Commit Bot
Comment 8 2019-08-29 21:18:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.