Summary: | Add phase, block, and node numbers to left margin of DFG graph dumps. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | fpizlo, keith_miller, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Mark Lam
2019-08-13 15:46:17 PDT
Created attachment 376221 [details]
proposed patch.
Comment on attachment 376221 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=376221&action=review > Source/JavaScriptCore/ChangeLog:46 > + The numbers in the left margin before the ':' are node number (index of node in not sure this I'd call this node number (since node number is the index that's used as an identifier). Just say node index inside basic block > Source/JavaScriptCore/dfg/DFGGraph.h:1007 > + void incPhase() { m_prefix.phaseNumber++; } maybe call this "nextPhase" or "startingNextPhase"? Comment on attachment 376221 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=376221&action=review >> Source/JavaScriptCore/ChangeLog:46 >> + The numbers in the left margin before the ':' are node number (index of node in > > not sure this I'd call this node number (since node number is the index that's used as an identifier). Just say node index inside basic block There's already a m_index and index() in DFGNode, but I'll just clarify that I mean a different index here. >> Source/JavaScriptCore/dfg/DFGGraph.h:1007 >> + void incPhase() { m_prefix.phaseNumber++; } > > maybe call this "nextPhase" or "startingNextPhase"? Will rename to nextPhase. Thanks for the review. Landed in r248642: <http://trac.webkit.org/r248642>. |