Bug 200681

Summary: [WHLSL] Don't generate empty comma expressions for bare ';'
Product: WebKit Reporter: Robin Morisset <rmorisset>
Component: WebGPUAssignee: Robin Morisset <rmorisset>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 199726    
Attachments:
Description Flags
Patch none

Robin Morisset
Reported 2019-08-13 11:45:58 PDT
Currently we emit a comma expression with no sub-expression for bare ';', as well as for the initialization of for loops with no initializers. This crashes the Checker, as it tries to access the last sub-expression of comma expressions. Instead we should generate an empty statement block for that case. This problem was found (and originally fixed before the commit was reverted) in https://bugs.webkit.org/show_bug.cgi?id=199726. I am just isolating the fix here for easier review and debugging.
Attachments
Patch (10.65 KB, patch)
2019-08-13 11:49 PDT, Robin Morisset 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Robin Morisset
Comment 1 2019-08-13 11:49:31 PDT
Created attachment 376189 [details] Patch
WebKit Commit Bot
Comment 2 2019-08-13 18:05:33 PDT
Comment on attachment 376189 [details] Patch Clearing flags on attachment: 376189 Committed r248650: <https://trac.webkit.org/changeset/248650>
WebKit Commit Bot
Comment 3 2019-08-13 18:05:35 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-08-13 18:06:21 PDT
<rdar://problem/54282997>
Note You need to log in before you can comment on or make changes to this bug.