Bug 200680 – Uncaught Exception: content.isJSON is not a function selecting image resource

• Component: Web Inspector
• Status: RESOLVED FIXED

[Joseph Pecoraro]

Uncaught Exception: content.isJSON is not a function selecting image resource

* STEPS TO REPRODUCE
1. Inspect http://bogojoker.com/shell/
2. Click the gif in the Sources tab
  => Exception

[Joseph Pecoraro]

Created attachment 376186 [details]
[PATCH] Proposed Fix

[Devin Rousso]

Comment on attachment 376186 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=376186&action=review

r=me

Interesting.  What's the type of the content for image resources?  I'd imagine it's a string that's `base64Encoded`?

> Source/WebInspectorUI/ChangeLog:10
> +        Protect against null, such as there being no request data.

There should already be a guard for protecting against no request data (`_canShowRequestContentView`).  Was that the issue in this case, or was it just for `null`?

[Joseph Pecoraro]

Created attachment 376208 [details]
[PATCH] For Landing

[Joseph Pecoraro]

(In reply to Devin Rousso from comment #2)
> Comment on attachment 376186 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=376186&action=review
> 
> Interesting.  What's the type of the content for image resources?  I'd
> imagine it's a string that's `base64Encoded`?

In this case it is a Blob. I've clarified the ChangeLog.

[WebKit Commit Bot]

Comment on attachment 376208 [details]
[PATCH] For Landing

Clearing flags on attachment: 376208

Committed r248637: <https://trac.webkit.org/changeset/248637>

[Radar WebKit Bug Importer]

<rdar://problem/54288272>