Summary: | Uncaught Exception: content.isJSON is not a function selecting image resource | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||
Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
URL: | http://bogojoker.com/shell/ | ||||||||
Attachments: |
|
Description
Joseph Pecoraro
2019-08-13 11:34:09 PDT
Created attachment 376186 [details]
[PATCH] Proposed Fix
Comment on attachment 376186 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=376186&action=review r=me Interesting. What's the type of the content for image resources? I'd imagine it's a string that's `base64Encoded`? > Source/WebInspectorUI/ChangeLog:10 > + Protect against null, such as there being no request data. There should already be a guard for protecting against no request data (`_canShowRequestContentView`). Was that the issue in this case, or was it just for `null`? Created attachment 376208 [details]
[PATCH] For Landing
(In reply to Devin Rousso from comment #2) > Comment on attachment 376186 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=376186&action=review > > Interesting. What's the type of the content for image resources? I'd > imagine it's a string that's `base64Encoded`? In this case it is a Blob. I've clarified the ChangeLog. Comment on attachment 376208 [details] [PATCH] For Landing Clearing flags on attachment: 376208 Committed r248637: <https://trac.webkit.org/changeset/248637> |