|Summary:||adding animation property support to RenderStyle|
|Product:||WebKit||Reporter:||Dean Jackson <dino>|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
|Bug Depends on:||19938|
Description Dean Jackson 2008-07-16 17:52:02 PDT
RenderStyle and its Transition class needs to be extended to support the animation properties: - direction - iterationCount - playState - name This patch adds these properties, but doesn't actually set them (ie. does not implement the CSS parsing part).
Comment 1 Dean Jackson 2008-07-16 17:53:15 PDT
Created attachment 22327 [details] adds animation properties into RenderStyle and Transition
Comment 2 Dave Hyatt 2008-07-23 13:53:11 PDT
Comment on attachment 22327 [details] adds animation properties into RenderStyle and Transition - setStyle(style); + if (style) + setStyle(style); setAnimatableStyle should never be called with a null style. This smacks of working around some other problem. If you have a test case where a null style was set, then we should be debugging how that happened and stop it rather than throwing in an unnecessary null check. I think "Transition" could ultimately be split up into multiple classes (it seems gross to have all the animation and transition properties together in a single class that is still called "Transition"). I think this could be done later though. Keyframes are all wrong, but I have promised to look the other way for this initial landing. EAnimPlayState is only 2 bits so could really be part of the "isSet" bitfield properties if you moved it to after the keyframe list and made it into: unsigned m_playState : 2; (unsigned for Windows compiler's benefit) That would save a bit of memory. r=me without making these changes, but I'd like to see the null check removed.
Comment 3 Dave Hyatt 2008-07-23 13:58:51 PDT
Comment on attachment 22327 [details] adds animation properties into RenderStyle and Transition Oh I also forgot that KeyframeList needs to be updated to the new refcounting model (with a create function). That's probably enough to tip this over into needing a new patch.
Comment 4 Simon Fraser (smfr) 2008-07-23 14:02:08 PDT
Filed bug 20148 on fixing keyframes to not live in RenderStyle.
Comment 5 Dave Hyatt 2008-07-23 14:11:41 PDT
Comment on attachment 22327 [details] adds animation properties into RenderStyle and Transition Ok, r=me assuming cleanup is done.
Comment 6 Dean Jackson 2008-07-25 18:08:59 PDT
Created attachment 22489 [details] updated patch Updated patch with review fixes. It won't be committed until a blocking patch lands.
Comment 7 Dean Jackson 2008-07-31 10:45:32 PDT
Created attachment 22579 [details] Second update to patch Second update to patch. Hyatt already gave a review+. This is waiting on the blocking bug before it can be landed.