Bug 200673

Summary: Incorrect head in fast/canvas/webgl/gl-get-calls.html causes test failure
Product: WebKit Reporter: Chris Lord <clord>
Component: Tools / TestsAssignee: Chris Lord <clord>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, darin, dino, fpizlo, mark.lam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch none

Chris Lord
Reported 2019-08-13 08:47:12 PDT
fast/canvas/webgl/gl-get-calls.html incorrectly puts xmlns="http://www.w3.org/1999/xhtml" in its html tag, which causes it to be treated as xhtml when using libsoup (as used on the Gtk and WPE backends). As it isn't well-formed, this causes the test to fail.
Attachments
Patch (1.13 KB, patch)
2019-08-13 08:52 PDT, Chris Lord 		no flags
DetailsFormatted DiffDiff
Patch (1.13 KB, patch)
2019-08-13 09:24 PDT, Chris Lord 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Lord
Comment 1 2019-08-13 08:52:05 PDT
Created attachment 376169 [details] Patch
Alexey Proskuryakov
Comment 2 2019-08-13 09:09:07 PDT
Comment on attachment 376169 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376169&action=review I would call this a real bug in these ports, as content sniffing local files is no less dangerous than content sniffing resources served by HTTP. This file just shouldn't be parsed as XML. Also, there is an explicit meta http-equiv that should be respected when content sniffing. But it's OK to correct the test. > LayoutTests/fast/canvas/webgl/gl-get-calls.html:1 > +<!DOCTYPE HTML> HTML5 doctype is "<!DOCTYPE html>" (lower case).
Chris Lord
Comment 3 2019-08-13 09:24:20 PDT
Created attachment 376172 [details] Patch
WebKit Commit Bot
Comment 4 2019-08-13 10:16:35 PDT
Comment on attachment 376172 [details] Patch Clearing flags on attachment: 376172 Committed r248599: <https://trac.webkit.org/changeset/248599>
WebKit Commit Bot
Comment 5 2019-08-13 10:16:37 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-08-13 10:17:19 PDT
<rdar://problem/54262996>
Note You need to log in before you can comment on or make changes to this bug.