Bug 200673

Summary: Incorrect head in fast/canvas/webgl/gl-get-calls.html causes test failure
Product: WebKit Reporter: Chris Lord <clord>
Component: Tools / TestsAssignee: Chris Lord <clord>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, darin, dino, fpizlo, mark.lam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Lord 2019-08-13 08:47:12 PDT
fast/canvas/webgl/gl-get-calls.html incorrectly puts xmlns="http://www.w3.org/1999/xhtml" in its html tag, which causes it to be treated as xhtml when using libsoup (as used on the Gtk and WPE backends). As it isn't well-formed, this causes the test to fail.
Comment 1 Chris Lord 2019-08-13 08:52:05 PDT
Created attachment 376169 [details]
Patch
Comment 2 Alexey Proskuryakov 2019-08-13 09:09:07 PDT
Comment on attachment 376169 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376169&action=review

I would call this a real bug in these ports, as content sniffing local files is no less dangerous than content sniffing resources served by HTTP. This file just shouldn't be parsed as XML. Also, there is an explicit meta http-equiv that should be respected when content sniffing.

But it's OK to correct the test.

> LayoutTests/fast/canvas/webgl/gl-get-calls.html:1
> +<!DOCTYPE HTML>

HTML5 doctype is "<!DOCTYPE html>" (lower case).
Comment 3 Chris Lord 2019-08-13 09:24:20 PDT
Created attachment 376172 [details]
Patch
Comment 4 WebKit Commit Bot 2019-08-13 10:16:35 PDT
Comment on attachment 376172 [details]
Patch

Clearing flags on attachment: 376172

Committed r248599: <https://trac.webkit.org/changeset/248599>
Comment 5 WebKit Commit Bot 2019-08-13 10:16:37 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-08-13 10:17:19 PDT
<rdar://problem/54262996>