Bug 200667

Summary: [JSCOnly] build broken on macOS due to missing include file
Product: WebKit Reporter: Samuel Groß <saelo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: achristensen, commit-queue, fpizlo, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: macOS 10.14   
Attachments:
Description Flags
Patch none

Samuel Groß
Reported 2019-08-13 02:49:54 PDT
The JSCOnly build on macOS appears to be broken (probably) after https://trac.webkit.org/changeset/248441/webkit: > ./Tools/Scripts/build-jsc --jsc-only --debug ... ../../Source/JavaScriptCore/jsc.cpp:141:10: fatal error: 'wtf/spi/darwin/ProcessMemoryFootprint.h' file not found #include <wtf/spi/darwin/ProcessMemoryFootprint.h> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. ninja: build stopped: subcommand failed.
Attachments
Patch (1.44 KB, patch)
2019-08-14 00:50 PDT, Samuel Groß 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2019-08-13 15:33:00 PDT
Would you be willing to post a patch for this? https://webkit.org/contributing-code/
Samuel Groß
Comment 2 2019-08-14 00:50:04 PDT
Created attachment 376245 [details] Patch
Samuel Groß
Comment 3 2019-08-14 00:55:41 PDT
I attempted to create a patch for this. I'm not sure if that's the correct place to add the include file, but `./Tools/Scripts/build-jsc --jsc-only --debug` does seem to work now.
WebKit Commit Bot
Comment 4 2019-08-14 09:39:21 PDT
Comment on attachment 376245 [details] Patch Clearing flags on attachment: 376245 Committed r248672: <https://trac.webkit.org/changeset/248672>
WebKit Commit Bot
Comment 5 2019-08-14 09:39:23 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-08-14 09:40:18 PDT
<rdar://problem/54305336>
Note You need to log in before you can comment on or make changes to this bug.