Bug 200656

Summary: [LFC][TFC] Introduce TableGrid
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description zalan 2019-08-12 21:13:57 PDT 
Table grid -> A matrix containing as many rows and columns as needed to describe the position of all the table-rows and table-cells of a table-root, as determined by the grid-dimensioning algorithm.
Each row of the grid might correspond to a table-row, and each column to a table-column.

https://www.w3.org/TR/css-tables-3/#terminology
Comment 1 Radar WebKit Bug Importer 2019-08-12 21:14:33 PDT 
<rdar://problem/54240833>
Comment 2 zalan 2019-08-12 21:22:46 PDT 
Created attachment 376136 [details]
Patch
Comment 3 Antti Koivisto 2019-08-13 07:38:47 PDT 
Comment on attachment 376136 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376136&action=review

> Source/WebCore/layout/tableformatting/TableGrid.h:63
> +        SlotInfo(CellInfo*);

Reference?

> Source/WebCore/layout/tableformatting/TableGrid.h:65
> +        CellInfo* cell { nullptr };

WeakPtr?
Comment 4 zalan 2019-08-13 08:42:46 PDT 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 376136 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=376136&action=review
> 
> > Source/WebCore/layout/tableformatting/TableGrid.h:63
> > +        SlotInfo(CellInfo*);
> 
> Reference?
> 
> > Source/WebCore/layout/tableformatting/TableGrid.h:65
> > +        CellInfo* cell { nullptr };
> 
> WeakPtr?
rookie mistake.
Comment 5 zalan 2019-08-13 08:44:19 PDT 
Created attachment 376168 [details]
Patch
Comment 6 WebKit Commit Bot 2019-08-13 10:05:26 PDT 
Comment on attachment 376168 [details]
Patch

Clearing flags on attachment: 376168

Committed r248596: <https://trac.webkit.org/changeset/248596>
Comment 7 WebKit Commit Bot 2019-08-13 10:05:27 PDT 
All reviewed patches have been landed.  Closing bug.