Bug 200656 – [LFC][TFC] Introduce TableGrid

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[zalan]

Table grid -> A matrix containing as many rows and columns as needed to describe the position of all the table-rows and table-cells of a table-root, as determined by the grid-dimensioning algorithm.
Each row of the grid might correspond to a table-row, and each column to a table-column.

https://www.w3.org/TR/css-tables-3/#terminology

[Radar WebKit Bug Importer]

<rdar://problem/54240833>

[zalan]

Created attachment 376136 [details]
Patch

[Antti Koivisto]

Comment on attachment 376136 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376136&action=review

> Source/WebCore/layout/tableformatting/TableGrid.h:63
> +        SlotInfo(CellInfo*);

Reference?

> Source/WebCore/layout/tableformatting/TableGrid.h:65
> +        CellInfo* cell { nullptr };

WeakPtr?

[zalan]

(In reply to Antti Koivisto from comment #3)
> Comment on attachment 376136 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=376136&action=review
> 
> > Source/WebCore/layout/tableformatting/TableGrid.h:63
> > +        SlotInfo(CellInfo*);
> 
> Reference?
> 
> > Source/WebCore/layout/tableformatting/TableGrid.h:65
> > +        CellInfo* cell { nullptr };
> 
> WeakPtr?
rookie mistake.

[zalan]

Created attachment 376168 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 376168 [details]
Patch

Clearing flags on attachment: 376168

Committed r248596: <https://trac.webkit.org/changeset/248596>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.