[LFC][TFC] Add rowSpan and colSpan to Box

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[zalan]

they are part of the random DOM things.

[Radar WebKit Bug Importer]

<rdar://problem/54239281>

[zalan]

Created attachment 376135 [details]
Patch

[Antti Koivisto]

Comment on attachment 376135 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376135&action=review

> Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:193
> +    if (is<RenderTableCell>(renderer)) {
> +        auto& cellElement = downcast<HTMLTableCellElement>(*renderer.element());
> +        auto rowSpan = cellElement.rowSpan();
> +        if (rowSpan > 1)
> +            childLayoutBox->setRowSpan(rowSpan);
> +
> +        auto columnSpan = cellElement.colSpan();
> +        if (columnSpan > 1)
> +            childLayoutBox->setColumnSpan(columnSpan);
> +    }

You will probably also need invalidation for dynamic changes. See RenderTableCell::colSpanOrRowSpanChanged and callers.

[zalan]

(In reply to Antti Koivisto from comment #3)
> Comment on attachment 376135 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=376135&action=review
> 
> > Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:193
> > +    if (is<RenderTableCell>(renderer)) {
> > +        auto& cellElement = downcast<HTMLTableCellElement>(*renderer.element());
> > +        auto rowSpan = cellElement.rowSpan();
> > +        if (rowSpan > 1)
> > +            childLayoutBox->setRowSpan(rowSpan);
> > +
> > +        auto columnSpan = cellElement.colSpan();
> > +        if (columnSpan > 1)
> > +            childLayoutBox->setColumnSpan(columnSpan);
> > +    }
> 
> You will probably also need invalidation for dynamic changes. See
> RenderTableCell::colSpanOrRowSpanChanged and callers.
Absolutely. At this point LFC does not deal with incremental changes. Each layout frame starts from scratch.

[WebKit Commit Bot]

Comment on attachment 376135 [details]
Patch

Clearing flags on attachment: 376135

Committed r248594: <https://trac.webkit.org/changeset/248594>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.