Summary: | [REGRESSION] run-webkit-tests: No PID defined when searching for simulator crashlogs | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||
Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aakash_jain, ap, commit-queue, ews-watchlist, glenn, Hironori.Fujii, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Jonathan Bedard
2019-08-12 14:43:12 PDT
Created attachment 376096 [details]
Patch
Comment on attachment 376096 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376096&action=review > Tools/Scripts/webkitpy/port/simulator_process.py:97 > + self._system_pid = self._pid Where/how is this _system_pid used? > Where/how is this _system_pid used?
Just noticed your comment 'SimulatorProcess inherits from ServerProcess'.
That makes sense. Can you please copy/paste the exception which this patch is fixing.
Thanks. LGTM. (In reply to Aakash Jain from comment #3) > > Where/how is this _system_pid used? > Just noticed your comment 'SimulatorProcess inherits from ServerProcess'. > > That makes sense. Can you please copy/paste the exception which this patch > is fixing. Not really an exception (that's what took us so long to notice the problem), <https://trac.webkit.org/changeset/245544/webkit> does a good job of showing how we use system_pid. Basically, we're using it to piece together crashlogs. If it's not defined, we search by process name and pull the first crash log that matches the process name. Nothing in Buildbot shows the failure at the moment, we need a configuration that's exotic enough to cause multiple crashes in a single run, I can't find any examples of that on build.webkit.org. Comment on attachment 376096 [details] Patch Clearing flags on attachment: 376096 Committed r248583: <https://trac.webkit.org/changeset/248583> All reviewed patches have been landed. Closing bug. |