Bug 200644 – [REGRESSION] run-webkit-tests: No PID defined when searching for simulator crashlogs

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Jonathan Bedard]

This is a regression from <https://trac.webkit.org/changeset/245544/webkit>. The SimulatorProcess inherits from ServerProcess, so it also needs to define _system_pid. We didn't notice this before because you need the same process to crash multiple times in a given test run for this to actually be an issue.

[Jonathan Bedard]

Created attachment 376096 [details]
Patch

[Aakash Jain]

Comment on attachment 376096 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376096&action=review

> Tools/Scripts/webkitpy/port/simulator_process.py:97
> +        self._system_pid = self._pid

Where/how is this _system_pid used?

[Aakash Jain]

> Where/how is this _system_pid used?
Just noticed your comment 'SimulatorProcess inherits from ServerProcess'.

That makes sense. Can you please copy/paste the exception which this patch is fixing.

[Fujii Hironori]

Thanks. LGTM.

[Jonathan Bedard]

(In reply to Aakash Jain from comment #3)
> > Where/how is this _system_pid used?
> Just noticed your comment 'SimulatorProcess inherits from ServerProcess'.
> 
> That makes sense. Can you please copy/paste the exception which this patch
> is fixing.

Not really an exception (that's what took us so long to notice the problem), <https://trac.webkit.org/changeset/245544/webkit> does a good job of showing how we use system_pid. Basically, we're using it to piece together crashlogs. If it's not defined, we search by process name and pull the first crash log that matches the process name. Nothing in Buildbot shows the failure at the moment, we need a configuration that's exotic enough to cause multiple crashes in a single run, I can't find any examples of that on build.webkit.org.

[WebKit Commit Bot]

Comment on attachment 376096 [details]
Patch

Clearing flags on attachment: 376096

Committed r248583: <https://trac.webkit.org/changeset/248583>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/54233104>