Bug 200632

Summary:

[WHLSL] TypeNamer can be simplified by replacing BaseTypeNameNode with uniqued AST::UnnamedTypes

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, mmaxfield, rmorisset, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Sam Weinig

Reported 2019-08-12 10:42:07 PDT

[WHLSL] TypeNamer can be simplified by replacing BaseTypeNameNode with uniqued AST::UnnamedTypes

Attachments
Patch (27.40 KB, patch) 2019-08-12 11:00 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (27.40 KB, patch) 2019-08-13 09:37 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (25.82 KB, patch) 2019-08-17 13:58 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (25.73 KB, patch) 2019-08-24 19:38 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2019-08-12 11:00:52 PDT

Created attachment 376080 [details] Patch

Sam Weinig

Comment 2 2019-08-13 09:37:13 PDT

Created attachment 376175 [details] Patch

Sam Weinig

Comment 3 2019-08-16 20:11:45 PDT

Saam, any thoughts on this?

Myles C. Maxfield

Comment 4 2019-08-16 21:04:16 PDT

Comment on attachment 376175 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376175&action=review > Source/WebCore/ChangeLog:11 > + There is no longer a reason to keep a parallel tree of the UnnamedType-like objects > + BaseTypeNameNodes. Instead, we can store a single HashMap mapping from UnnamedTypeKeys > + to MangledTypeName, and use the the UnnamedType stored in the UnnamedTypeKey while > + emitting the metal code. What's the motivation for this?

Sam Weinig

Comment 5 2019-08-16 22:30:45 PDT

(In reply to Myles C. Maxfield from comment #4) > Comment on attachment 376175 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=376175&action=review > > > Source/WebCore/ChangeLog:11 > > + There is no longer a reason to keep a parallel tree of the UnnamedType-like objects > > + BaseTypeNameNodes. Instead, we can store a single HashMap mapping from UnnamedTypeKeys > > + to MangledTypeName, and use the the UnnamedType stored in the UnnamedTypeKey while > > + emitting the metal code. > > What's the motivation for this? Simplifying the code. Removing unnecessary indirection.

Sam Weinig

Comment 6 2019-08-17 13:58:34 PDT

Created attachment 376613 [details] Patch

Sam Weinig

Comment 7 2019-08-24 19:38:14 PDT

Created attachment 377219 [details] Patch

Saam Barati

Comment 8 2019-08-26 11:26:12 PDT

Comment on attachment 377219 [details] Patch Nice. r=me

WebKit Commit Bot

Comment 9 2019-08-26 11:58:07 PDT

Comment on attachment 377219 [details] Patch Clearing flags on attachment: 377219 Committed r249109: <https://trac.webkit.org/changeset/249109>