Bug 200612

Summary:

Factor complex line layout path out from RenderBlockFlow

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, ews-watchlist, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
patch	zalan: review+
patch	none

Description Antti Koivisto 2019-08-10 08:46:39 PDT

Move the code in RenderBlockLineLayout.cpp into a class of its own.

Comment 1 Antti Koivisto 2019-08-10 09:12:44 PDT

Created attachment 376012 [details]
patch

Comment 2 EWS Watchlist 2019-08-10 09:14:01 PDT

Attachment 376012 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:219:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:221:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:227:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:336:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:346:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:878:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:878:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:879:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:999:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:1009:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:1111:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:1293:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:1302:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:1571:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:1575:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:1675:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:1684:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:1738:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:1763:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:1772:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:1824:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:1903:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:2139:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:2151:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:2152:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 25 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Antti Koivisto 2019-08-10 10:20:47 PDT

Created attachment 376014 [details]
patch

Comment 4 EWS Watchlist 2019-08-10 10:22:11 PDT

Attachment 376014 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:1110:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:1570:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:1574:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:1771:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:1902:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
Total errors found: 5 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Antti Koivisto 2019-08-11 00:37:35 PDT

Created attachment 376032 [details]
patch

Comment 6 EWS Watchlist 2019-08-11 03:08:14 PDT

Attachment 376032 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:1110:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:1570:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:1574:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:1771:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
ERROR: Source/WebCore/rendering/ComplexLineLayout.cpp:1902:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
Total errors found: 5 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 7 WebKit Commit Bot 2019-08-11 04:02:08 PDT

Comment on attachment 376032 [details]
patch

Clearing flags on attachment: 376032

Committed r248517: <https://trac.webkit.org/changeset/248517>

Comment 8 WebKit Commit Bot 2019-08-11 04:02:09 PDT

All reviewed patches have been landed.  Closing bug.

Comment 9 Radar WebKit Bug Importer 2019-08-11 04:03:22 PDT

<rdar://problem/54178193>