Bug 200603

Summary: Web Inspector: Node details sidebar sections have unclear delineation in Dark Mode
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, commit-queue, dino, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[IMAGE] Before
none
[IMAGE] After
none
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2019-08-09 19:28:46 PDT
Node details sidebar sections have unclear delineation in Dark Mode Saw this on Brady's machine today and Dean mentioned it as well. Lets just fix it!
Attachments
[IMAGE] Before (706.30 KB, image/png)
2019-08-09 19:29 PDT, Joseph Pecoraro 		no flags
Details
[IMAGE] After (706.85 KB, image/png)
2019-08-09 19:29 PDT, Joseph Pecoraro 		no flags
Details
[PATCH] Proposed Fix (1.64 KB, patch)
2019-08-09 19:34 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2019-08-09 19:29:01 PDT
<rdar://problem/54146925>
Joseph Pecoraro
Comment 2 2019-08-09 19:29:36 PDT
Created attachment 375991 [details] [IMAGE] Before
Joseph Pecoraro
Comment 3 2019-08-09 19:29:47 PDT
Created attachment 375992 [details] [IMAGE] After
Joseph Pecoraro
Comment 4 2019-08-09 19:34:29 PDT
Created attachment 375994 [details] [PATCH] Proposed Fix Removed the rule for the Computed as it didn't make sense anyways.
Devin Rousso
Comment 5 2019-08-09 19:36:41 PDT
Comment on attachment 375994 [details] [PATCH] Proposed Fix r=me, I like it!
WebKit Commit Bot
Comment 6 2019-08-09 20:19:58 PDT
Comment on attachment 375994 [details] [PATCH] Proposed Fix Clearing flags on attachment: 375994 Committed r248495: <https://trac.webkit.org/changeset/248495>
WebKit Commit Bot
Comment 7 2019-08-09 20:19:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.