Bug 200596

Summary: [WHLSL] Make lexing faster
Product: WebKit Reporter: Saam Barati <saam>
Component: WebGPUAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, ews-watchlist, fpizlo, jonlee, justin_fan, mmaxfield, rmorisset, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
WIP
none
patch
mmaxfield: review+
patch for landing saam: commit-queue-

Saam Barati
Reported 2019-08-09 15:47:00 PDT
We spend like 4ms total in consumeTokenFromStream in compute_boids
Attachments
WIP (68.90 KB, patch)
2019-08-09 19:33 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
WIP (99.56 KB, patch)
2019-08-12 16:59 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (70.44 KB, patch)
2019-08-12 20:13 PDT, Saam Barati 		mmaxfield: review+
DetailsFormatted DiffDiff
patch for landing (73.87 KB, patch)
2019-08-13 12:23 PDT, Saam Barati 		saam: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2019-08-09 19:33:59 PDT
Created attachment 375993 [details] WIP it begins
Saam Barati
Comment 2 2019-08-12 16:59:32 PDT
Created attachment 376108 [details] WIP I think it's done. Gonna read over it once and then prepare the patch
Saam Barati
Comment 3 2019-08-12 20:13:07 PDT
Created attachment 376131 [details] patch
EWS Watchlist
Comment 4 2019-08-12 20:14:38 PDT
Attachment 376131 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:13: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebCore/ChangeLog:15: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Saam Barati
Comment 5 2019-08-13 12:23:04 PDT
Created attachment 376194 [details] patch for landing
Saam Barati
Comment 6 2019-08-13 20:01:05 PDT
landed in: https://trac.webkit.org/changeset/248658/webkit
Radar WebKit Bug Importer
Comment 7 2019-08-13 20:02:15 PDT
<rdar://problem/54286019>
Note You need to log in before you can comment on or make changes to this bug.