Summary: | ScrollingStateNode is not ThreadSafeRefCounted but is ref'd / deref'd from several threads | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | WebCore Misc. | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, cmarcelo, commit-queue, ews-watchlist, fred.wang, ggaren, jamesr, koivisto, luiz, simon.fraser, tonikitoo, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 200507 | ||||||||||
Attachments: |
|
Description
Chris Dumez
2019-08-08 13:09:22 PDT
Created attachment 375836 [details]
Patch
Comment on attachment 375836 [details]
Patch
In which thread is it supposed to be deleted?
Chris and I talked about this. We have an explicit hand-off of the state tree in ScrollingCoordinatorMac::commitTreeState() which may be tripping his assertions. Created attachment 375837 [details]
Patch
(In reply to Simon Fraser (smfr) from comment #3) > Chris and I talked about this. We have an explicit hand-off of the state > tree in ScrollingCoordinatorMac::commitTreeState() which may be tripping his > assertions. (In reply to Antti Koivisto from comment #2) > Comment on attachment 375836 [details] > Patch > > In which thread is it supposed to be deleted? I am not familiar enough with this part of the code to be sure, but looking at the ScrollingStateNode data members, I do not see anything obviously unsafe if constructing them on the main thread and then destroying them on the scrolling thread. Created attachment 375838 [details]
Patch
Comment on attachment 375838 [details] Patch Clearing flags on attachment: 375838 Committed r248445: <https://trac.webkit.org/changeset/248445> All reviewed patches have been landed. Closing bug. |