Make IDBRequest ThreadSafeRefCounted

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Chris Dumez]

Make IDBRequest ThreadSafeRefCounted, as it looks like it is being ref'd / deref'd from several threads:
Exception Type:        EXC_BREAKPOINT (SIGTRAP)
Exception Codes:       0x0000000000000002, 0x0000000000000000
Exception Note:        EXC_CORPSE_NOTIFY

Termination Signal:    Trace/BPT trap: 5
Termination Reason:    Namespace SIGNAL, Code 0x5
Terminating Process:   exc handler [0]

Application Specific Information:
CRASHING TEST: storage/indexeddb/pending-version-change-stuck-private.html

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.WebCore             	0x0000000113674fb3 0x113673000 + 8115
1   com.apple.WebCore             	0x0000000113f18f90 WTF::RefPtr<WebCore::IDBOpenDBRequest, WTF::DumbPtrTraits<WebCore::IDBOpenDBRequest> >::operator=(WebCore::IDBOpenDBRequest*) + 224 (Assertions.h:587)
2   com.apple.WebCore             	0x0000000113f18dcb WebCore::IDBClient::IDBConnectionProxy::notifyOpenDBRequestBlocked(WebCore::IDBResourceIdentifier const&, unsigned long long, unsigned long long) + 91 (Atomics.h:247)
3   com.apple.JavaScriptCore      	0x000000010f59652c WTF::RunLoop::performWork() + 236 (Function.h:79)
4   com.apple.JavaScriptCore      	0x000000010f5967d2 WTF::RunLoop::performWork(void*) + 34 (RunLoopCF.cpp:39)
5   com.apple.CoreFoundation      	0x00007fff4ca6b581 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
6   com.apple.CoreFoundation      	0x00007fff4cb238ac __CFRunLoopDoSource0 + 108
7   com.apple.CoreFoundation      	0x00007fff4ca4e530 __CFRunLoopDoSources0 + 208
8   com.apple.CoreFoundation      	0x00007fff4ca4d9ad __CFRunLoopRun + 1293
9   com.apple.CoreFoundation      	0x00007fff4ca4d207 CFRunLoopRunSpecific + 487
10  DumpRenderTree                	0x000000010f2b282f runTest(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 3601 (DumpRenderTree.mm:2087)
11  DumpRenderTree                	0x000000010f2b165a dumpRenderTree(int, char const**) + 3439 (DumpRenderTree.mm:1210)
12  DumpRenderTree                	0x000000010f2b30dd DumpRenderTreeMain(int, char const**) + 1456 (DumpRenderTree.mm:1442)
13  libdyld.dylib                 	0x00007fff74a0d015 start + 1

[Chris Dumez]

Created attachment 375813 [details]
Patch

[Alex Christensen]

Comment on attachment 375813 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375813&action=review

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:-8970
> -				CDA93DAE22F8BCF300490A69 /* FullscreenTouchSecheuristicParameters.h */,

Is all this stuff really necessary with this patch?

[Chris Dumez]

Comment on attachment 375813 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375813&action=review

>> Source/WebKit/WebKit.xcodeproj/project.pbxproj:-8970
>> -				CDA93DAE22F8BCF300490A69 /* FullscreenTouchSecheuristicParameters.h */,
> 
> Is all this stuff really necessary with this patch?

Not sure what happened there, I'll drop.

[Chris Dumez]

Created attachment 375814 [details]
Patch

[Chris Dumez]

Created attachment 375817 [details]
Patch

[Chris Dumez]

Created attachment 375818 [details]
Patch

[Chris Dumez]

Comment on attachment 375818 [details]
Patch

Clearing flags on attachment: 375818

Committed r248431: <https://trac.webkit.org/changeset/248431>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/54089344>

[Darin Adler]

Comment on attachment 375818 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375818&action=review

> Source/WebCore/Modules/indexeddb/IDBRequest.h:165
> +    void refEventTarget() final { ThreadSafeRefCounted::ref(); }
> +    void derefEventTarget() final { ThreadSafeRefCounted::deref(); }

I think we usually just write ref() and deref() here; works because of the using above.

[Chris Dumez]

(In reply to Darin Adler from comment #10)
> Comment on attachment 375818 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=375818&action=review
> 
> > Source/WebCore/Modules/indexeddb/IDBRequest.h:165
> > +    void refEventTarget() final { ThreadSafeRefCounted::ref(); }
> > +    void derefEventTarget() final { ThreadSafeRefCounted::deref(); }
> 
> I think we usually just write ref() and deref() here; works because of the
> using above.

Indeed, fixed in <https://trac.webkit.org/changeset/248439>, thanks.

[Fujii Hironori]

It seems that this change fixed WinCairo flaky indexeddb test failures. Thank you!

[Chris Dumez]

(In reply to Fujii Hironori from comment #12)
> It seems that this change fixed WinCairo flaky indexeddb test failures.
> Thank you!

Nice :)