Bug 200539

Summary: [FTW] Get WebKit, WebKit2, and MiniBrowser building and executing
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, dino, ews-watchlist, fujii.hironori, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari 10   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 161817    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Brent Fulgham
Reported 2019-08-08 09:06:55 PDT
This patch gets the remaining pieces of WebKit needed to run MiniBrowser working.
Attachments
Patch (155.76 KB, patch)
2019-08-08 11:06 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (147.58 KB, patch)
2019-08-08 11:33 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch for landing (147.10 KB, patch)
2019-08-08 13:16 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-08-08 09:20:25 PDT
<rdar://problem/54082550>
Brent Fulgham
Comment 2 2019-08-08 11:06:39 PDT
Created attachment 375823 [details] Patch
EWS Watchlist
Comment 3 2019-08-08 11:09:58 PDT
Attachment 375823 [details] did not pass style-queue: ERROR: Source/WebKit/PlatformFTW.cmake:177: Alphabetical sorting problem. "D2d1.lib" should be before "PRIVATE". [list/order] [5] Total errors found: 1 in 73 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brent Fulgham
Comment 4 2019-08-08 11:33:09 PDT
Created attachment 375826 [details] Patch
EWS Watchlist
Comment 5 2019-08-08 11:36:48 PDT
Attachment 375826 [details] did not pass style-queue: ERROR: Source/WebKit/PlatformFTW.cmake:177: Alphabetical sorting problem. "D2d1.lib" should be before "PRIVATE". [list/order] [5] Total errors found: 1 in 68 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brent Fulgham
Comment 6 2019-08-08 12:59:09 PDT
Windows is generating a weird error, that Google searching indicates is caused by a machine configuration issue: c:\program files (x86)\windows kits\10\include\10.0.17134.0\cppwinrt\winrt\base.h(10253): error C2039: 'GetSystemTimePreciseAsFileTime': is not a member of '`global namespace'' [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] c:\program files (x86)\windows kits\10\include\10.0.17134.0\cppwinrt\winrt\base.h(10253): error C3861: 'GetSystemTimePreciseAsFileTime': identifier not found [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] We do not use or reference 'GetSystemTimePreciseAsFileTime' anywhere.
Brent Fulgham
Comment 7 2019-08-08 13:09:09 PDT
Comment on attachment 375826 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375826&action=review > Source/WebKitLegacy/win/WebKitPrefix.h:34 > +#include <winrt/Windows.Foundation.Collections.h> Oh whoops! This is the build failure.
Brent Fulgham
Comment 8 2019-08-08 13:16:55 PDT
Created attachment 375834 [details] Patch for landing
EWS Watchlist
Comment 9 2019-08-08 14:24:45 PDT
Attachment 375834 [details] did not pass style-queue: ERROR: Source/WebKit/PlatformFTW.cmake:177: Alphabetical sorting problem. "D2d1.lib" should be before "PRIVATE". [list/order] [5] Total errors found: 1 in 67 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 10 2019-08-08 15:04:06 PDT
Comment on attachment 375834 [details] Patch for landing Clearing flags on attachment: 375834 Committed r248444: <https://trac.webkit.org/changeset/248444>
WebKit Commit Bot
Comment 11 2019-08-08 15:04:07 PDT
All reviewed patches have been landed. Closing bug.
Fujii Hironori
Comment 12 2019-11-29 01:08:45 PST
Comment on attachment 375834 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=375834&action=review > Source/WebKitLegacy/CMakeLists.txt:63 > + if (APPLE) Filed: Bug 204695 – [AppleWin] WebKitQuartzCoreAdditions.dll isn't compiled since r248444
Note You need to log in before you can comment on or make changes to this bug.