| Summary: | Web Inspector: rename `queryObjects` to `queryInstances` for clarity | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | bburg, commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, nvasilyev, rniwa, saam, tzagallo, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Bug Depends on: | 176766 | ||||||||||||
| Bug Blocks: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Devin Rousso
2019-08-07 15:55:23 PDT
Created attachment 375760 [details]
Patch
Do the other browsers (*cough cough* Chromium) plan to rename queryObjects as well? It does seem like a better name. (In reply to Nikita Vasilyev from comment #2) > Do the other browsers (*cough cough* Chromium) plan to rename queryObjects as well? It does seem like a better name. Not that I'm aware. This is another reason why I'm keeping an alias :P Comment on attachment 375760 [details] Patch Attachment 375760 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12876222 New failing tests: http/tests/inspector/dom/cross-domain-inspected-node-access.html Created attachment 375768 [details]
Archive of layout-test-results from ews101 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 375760 [details] Patch Attachment 375760 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12876290 New failing tests: http/tests/inspector/dom/cross-domain-inspected-node-access.html Created attachment 375772 [details]
Archive of layout-test-results from ews114 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 375780 [details]
Patch
Comment on attachment 375780 [details]
Patch
r=me
Comment on attachment 375780 [details] Patch Clearing flags on attachment: 375780 Committed r248434: <https://trac.webkit.org/changeset/248434> All reviewed patches have been landed. Closing bug. |