Bug 200479

Summary: [WPE][GTK] New API to remove a filter from an user content manager given its identifier
Product: WebKit Reporter: Adrian Perez <aperez>
Component: WebKit APIAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, commit-queue, mcatanzaro, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
URL: https://gitlab.gnome.org/GNOME/epiphany/merge_requests/405
Bug Depends on: 167941    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Adrian Perez 2019-08-06 15:27:31 PDT
Applications may not want to keep around a ref to a WebKitUserContentFilter
in order to disable the filter later on, and at the same time they may want
(or need) to selectively disable a filter without having to use the
webkit_user_content_manager_remove_all_filters() and then re-add the ones
they want to keep active.
Comment 1 Adrian Perez 2019-08-06 15:40:41 PDT
Created attachment 375654 [details]
Patch
Comment 2 Michael Catanzaro 2019-08-06 16:00:16 PDT
Comment on attachment 375654 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375654&action=review

First r=me, requires a second GTK/WPE reviewer

> Source/WebKit/UIProcess/API/glib/WebKitUserContentManager.cpp:358
> + * webkit_user_content_maager_remove_filter_by_id:

typo
Comment 3 Carlos Garcia Campos 2019-08-29 23:51:57 PDT
Comment on attachment 375654 [details]
Patch

Fix the typo in docs, please.
Comment 4 Adrian Perez 2019-08-30 05:36:32 PDT
Created attachment 377701 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-08-30 06:19:00 PDT
Comment on attachment 377701 [details]
Patch for landing

Clearing flags on attachment: 377701

Committed r249324: <https://trac.webkit.org/changeset/249324>
Comment 6 WebKit Commit Bot 2019-08-30 06:19:01 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-08-30 06:19:19 PDT
<rdar://problem/54879675>