Bug 200472

Summary: [WHLSL] Remove the auto initialize variables pass
Product: WebKit Reporter: Saam Barati <saam>
Component: WebGPUAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, fpizlo, jonlee, justin_fan, mmaxfield, rmorisset, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Saam Barati
Reported 2019-08-06 10:54:40 PDT
It's logically nicer to do this transformation over the AST, as it removes code that needs to be done in AST lowering to Metal. However, this phase takes ~1.2ms on compute_boids, and it's trivial to emit what this phase does in metal lowering. So we should just do that instead to gain some minor perf.
Attachments
patch (12.47 KB, patch)
2019-08-06 12:06 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2019-08-06 12:06:38 PDT
Created attachment 375640 [details] patch
Robin Morisset
Comment 2 2019-08-06 12:21:48 PDT
Comment on attachment 375640 [details] patch r=me Doesn't this also make synthesizeConstructors unnecessary? Since these constructors were only used in this pass I think.
Saam Barati
Comment 3 2019-08-06 12:37:16 PDT
(In reply to Robin Morisset from comment #2) > Comment on attachment 375640 [details] > patch > > r=me > Doesn't this also make synthesizeConstructors unnecessary? Since these > constructors were only used in this pass I think. Not quite, as user code can call these. But as Robin and I discussed offline, we could change this to not auto generate such things. However, I'll leave this for a future change after we discuss what to do.
WebKit Commit Bot
Comment 4 2019-08-06 13:31:10 PDT
Comment on attachment 375640 [details] patch Clearing flags on attachment: 375640 Committed r248310: <https://trac.webkit.org/changeset/248310>
WebKit Commit Bot
Comment 5 2019-08-06 13:31:12 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-08-06 13:32:18 PDT
<rdar://problem/54001035>
Note You need to log in before you can comment on or make changes to this bug.