Bug 200462

Summary: [WHLSL] cache results of argumentTypeForAndOverload inside Checker
Product: WebKit Reporter: Saam Barati <saam>
Component: WebGPUAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, fpizlo, jonlee, justin_fan, mmaxfield, rmorisset, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
patch
none
patch none

Saam Barati
Reported 2019-08-05 18:10:02 PDT
We spend 4-5ms in that function in compute_boids.
Attachments
WIP (23.95 KB, patch)
2019-08-06 19:44 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (9.14 KB, patch)
2019-08-06 21:32 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (9.14 KB, patch)
2019-08-06 21:35 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2019-08-06 19:43:23 PDT
Seems like a solid 4-5ms speedup in checker.
Saam Barati
Comment 2 2019-08-06 19:44:03 PDT
Created attachment 375678 [details] WIP need to rebase. But we have a 99% hit rate on compute_boids!
Saam Barati
Comment 3 2019-08-06 21:32:56 PDT
Created attachment 375683 [details] patch
Saam Barati
Comment 4 2019-08-06 21:34:19 PDT
Comment on attachment 375683 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=375683&action=review > Source/WebCore/Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp:-106 > - static const bool emptyValueIsZero = true; This was bogus, which is why I'm removing it. (This should belong on Traits. And we never use these Traits as values in a hash table.)
Saam Barati
Comment 5 2019-08-06 21:35:54 PDT
Created attachment 375685 [details] patch
Robin Morisset
Comment 6 2019-08-07 10:02:45 PDT
Comment on attachment 375685 [details] patch r=me
WebKit Commit Bot
Comment 7 2019-08-07 11:14:03 PDT
Comment on attachment 375685 [details] patch Clearing flags on attachment: 375685 Committed r248378: <https://trac.webkit.org/changeset/248378>
WebKit Commit Bot
Comment 8 2019-08-07 11:14:04 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-08-07 11:16:02 PDT
<rdar://problem/54041999>
Note You need to log in before you can comment on or make changes to this bug.