Bug 200422

Summary:

Web Inspector: rename "Stylesheet" to "Style Sheet" to match spec text

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, rniwa, ross.kirsling, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=195847

Attachments:

Description	Flags
Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews100 for mac-highsierra	none
Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews100 for mac-highsierra	none
Patch	none
Archive of layout-test-results from ews103 for mac-highsierra	none
Archive of layout-test-results from ews117 for mac-highsierra	none
Patch	none

Devin Rousso

Reported 2019-08-03 18:14:48 PDT

<https://www.w3.org/TR/html401/present/styles.html>

Attachments
Patch (37.36 KB, patch) 2019-08-03 20:32 PDT, Devin Rousso	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-highsierra (3.20 MB, application/zip) 2019-08-03 21:40 PDT, EWS Watchlist	no flags	Details
Patch (37.36 KB, patch) 2019-08-03 22:10 PDT, Devin Rousso	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-highsierra (3.20 MB, application/zip) 2019-08-03 23:19 PDT, EWS Watchlist	no flags	Details
Patch (37.36 KB, patch) 2019-08-03 23:29 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-highsierra (3.26 MB, application/zip) 2019-08-04 00:38 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews117 for mac-highsierra (2.99 MB, application/zip) 2019-08-04 01:18 PDT, EWS Watchlist	no flags	Details
Patch (37.55 KB, patch) 2019-08-04 19:24 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2019-08-03 20:32:00 PDT

Created attachment 375496 [details] Patch

EWS Watchlist

Comment 2 2019-08-03 20:33:24 PDT Comment hidden (obsolete)

This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.

EWS Watchlist

Comment 3 2019-08-03 21:40:50 PDT Comment hidden (obsolete)

Comment on attachment 375496 [details] Patch Attachment 375496 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12859125 New failing tests: http/tests/inspector/network/resource-mime-type.html

EWS Watchlist

Comment 4 2019-08-03 21:40:52 PDT Comment hidden (obsolete)

Created attachment 375497 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6

Devin Rousso

Comment 5 2019-08-03 22:10:02 PDT

Created attachment 375499 [details] Patch

EWS Watchlist

Comment 6 2019-08-03 23:19:28 PDT Comment hidden (obsolete)

Comment on attachment 375499 [details] Patch Attachment 375499 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12859353 New failing tests: http/tests/inspector/network/resource-mime-type.html

EWS Watchlist

Comment 7 2019-08-03 23:19:30 PDT Comment hidden (obsolete)

Created attachment 375500 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6

Devin Rousso

Comment 8 2019-08-03 23:29:58 PDT

Created attachment 375501 [details] Patch

EWS Watchlist

Comment 9 2019-08-04 00:38:35 PDT Comment hidden (obsolete)

Comment on attachment 375501 [details] Patch Attachment 375501 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12859527 New failing tests: http/tests/inspector/network/resource-mime-type.html

EWS Watchlist

Comment 10 2019-08-04 00:38:36 PDT Comment hidden (obsolete)

Created attachment 375502 [details] Archive of layout-test-results from ews103 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 11 2019-08-04 01:18:50 PDT Comment hidden (obsolete)

Comment on attachment 375501 [details] Patch Attachment 375501 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12859536 New failing tests: http/tests/inspector/network/resource-mime-type.html

EWS Watchlist

Comment 12 2019-08-04 01:18:51 PDT Comment hidden (obsolete)

Created attachment 375503 [details] Archive of layout-test-results from ews117 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6

Devin Rousso

Comment 13 2019-08-04 19:24:46 PDT

Created attachment 375514 [details] Patch

Ross Kirsling

Comment 14 2019-08-05 13:26:01 PDT

Hmm, consistency is definitely good, particularly in display text, but unfortunately it seems like they're kind of both right? It's true that WHATWG's current HTML spec seems to say "CSS style sheet" pretty consistently: https://html.spec.whatwg.org/multipage/rendering.html#the-css-user-agent-style-sheet-and-presentational-hints (Except, y'know, there's <link rel="stylesheet">. :P) But W3C's actual CSS specs are quite divided -- in fact, the current document describing how to parse CSS uses "stylesheet" throughout: https://www.w3.org/TR/css-syntax-3/ (Except for this one divergent subsection: https://www.w3.org/TR/css-syntax-3/#conform-classes) And conversationally, we certainly say "stylesheet" and not "style sheet" (like "bluebird" and not "blue bird"). 🤔 I don't have a strong opinion about which way the display text should be unified, but for identifiers, moving *toward* StyleSheet / style-sheet sort of gives me pause.

Joseph Pecoraro

Comment 15 2019-08-05 13:37:17 PDT

Comment on attachment 375514 [details] Patch r=me This may need an ITMLKit notification but I don't know.

WebKit Commit Bot

Comment 16 2019-08-05 15:44:16 PDT

Comment on attachment 375514 [details] Patch Clearing flags on attachment: 375514 Committed r248274: <https://trac.webkit.org/changeset/248274>

WebKit Commit Bot

Comment 17 2019-08-05 15:44:18 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 18 2019-08-05 15:45:29 PDT

<rdar://problem/53962273>

Note You need to log in before you can comment on or make changes to this bug.