| Summary: | Web Inspector: rename "Stylesheet" to "Style Sheet" to match spec text | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||||||||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, rniwa, ross.kirsling, saam, tzagallo, webkit-bug-importer | ||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||
| Hardware: | All | ||||||||||||||||||||
| OS: | All | ||||||||||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=195847 | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Devin Rousso
2019-08-03 18:14:48 PDT
Created attachment 375496 [details]
Patch
This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features. Comment on attachment 375496 [details] Patch Attachment 375496 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12859125 New failing tests: http/tests/inspector/network/resource-mime-type.html Created attachment 375497 [details]
Archive of layout-test-results from ews100 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 375499 [details]
Patch
Comment on attachment 375499 [details] Patch Attachment 375499 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12859353 New failing tests: http/tests/inspector/network/resource-mime-type.html Created attachment 375500 [details]
Archive of layout-test-results from ews100 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 375501 [details]
Patch
Comment on attachment 375501 [details] Patch Attachment 375501 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12859527 New failing tests: http/tests/inspector/network/resource-mime-type.html Created attachment 375502 [details]
Archive of layout-test-results from ews103 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 375501 [details] Patch Attachment 375501 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12859536 New failing tests: http/tests/inspector/network/resource-mime-type.html Created attachment 375503 [details]
Archive of layout-test-results from ews117 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 375514 [details]
Patch
Hmm, consistency is definitely good, particularly in display text, but unfortunately it seems like they're kind of both right? It's true that WHATWG's current HTML spec seems to say "CSS style sheet" pretty consistently: https://html.spec.whatwg.org/multipage/rendering.html#the-css-user-agent-style-sheet-and-presentational-hints (Except, y'know, there's <link rel="stylesheet">. :P) But W3C's actual CSS specs are quite divided -- in fact, the current document describing how to parse CSS uses "stylesheet" throughout: https://www.w3.org/TR/css-syntax-3/ (Except for this one divergent subsection: https://www.w3.org/TR/css-syntax-3/#conform-classes) And conversationally, we certainly say "stylesheet" and not "style sheet" (like "bluebird" and not "blue bird"). 🤔 I don't have a strong opinion about which way the display text should be unified, but for identifiers, moving *toward* StyleSheet / style-sheet sort of gives me pause. Comment on attachment 375514 [details]
Patch
r=me
This may need an ITMLKit notification but I don't know.
Comment on attachment 375514 [details] Patch Clearing flags on attachment: 375514 Committed r248274: <https://trac.webkit.org/changeset/248274> All reviewed patches have been landed. Closing bug. |