UI frozen when the debugger is paused

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Anthony Ricaud]

In certain cases, the inspector UI can be frozen while the debugger is paused. I've found one way to reproduce this, there might be others.

The test uses /loaded|complete/.test(document.readyState) to simulate DOMContentLoaded. It's a test widely used for earlier versions of WebKit.

Steps to reproduce:
1) Open the testcase
2) Open the inspector
3) Try to show/hide the console.

Actual behaviour:
The console panel doesn't open

Expected behaviour:
The console panel should open

[Anthony Ricaud]

Created attachment 22280 [details]
Testcase

[Anthony Ricaud]

Created attachment 22281 [details]
Real testcase

[Anthony Ricaud]

(In reply to comment #0)
> In certain cases, the inspector UI can be frozen while the debugger is paused.
> I've found one way to reproduce this, there might be others.
> 
> The test uses /loaded|complete/.test(document.readyState) to simulate
> DOMContentLoaded. It's a test widely used for earlier versions of WebKit.
> 
> Steps to reproduce:
> 1) Open the testcase
> 2) Open the inspector
> 3) Try to show/hide the console.
> 
> Actual behaviour:
> The console panel doesn't open
> 
> Expected behaviour:
> The console panel should open
> 
Sorry for the wrong steps. New ones :
1) Open the testcase
2) Open the inspector
3) Enable the script debugger (the page reloads)
4) Try to show/hide the console.

[Timothy Hatcher]

Created attachment 22945 [details]
Proposed patch

[Darin Adler]

Comment on attachment 22945 [details]
Proposed patch

r=me

This seems like the right fix unless we can change the design so fireTimersInNestedEventLoop is no longer needed. I'm still hoping we can do that some day.

[Timothy Hatcher]

Landed in r35908.