Bug 200400

Summary:

New EWS:mac-wk2 status-bubble shows waiting to run tests for all recent bugs

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, jbedard, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=199960
https://bugs.webkit.org/show_bug.cgi?id=200401

Attachments:

Description	Flags
Bubble status	none
EWS Mac-wk2 status page	none
Tooltip when you hover over Mac-wk2 bubble	none
Patch	none

Daniel Bates

Reported 2019-08-02 11:46:21 PDT

The patch for bug #199960 (attachment #374973 [details]) has been waiting for a Mac WK1 tester for 7 days now.

Attachments
Bubble status (300.72 KB, image/png) 2019-08-02 11:46 PDT, Daniel Bates	no flags	Details
EWS Mac-wk2 status page (426.88 KB, image/png) 2019-08-02 11:48 PDT, Daniel Bates	no flags	Details
Tooltip when you hover over Mac-wk2 bubble (176.80 KB, image/png) 2019-08-02 11:49 PDT, Daniel Bates	no flags	Details
Patch (2.63 KB, patch) 2019-08-05 13:36 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2019-08-02 11:46:54 PDT

Created attachment 375436 [details] Bubble status

Radar WebKit Bug Importer

Comment 2 2019-08-02 11:48:20 PDT

<rdar://problem/53872439>

Daniel Bates

Comment 3 2019-08-02 11:48:30 PDT

Created attachment 375437 [details] EWS Mac-wk2 status page <https://ews-build.webkit.org/#/builders/7/builds/5822>

Daniel Bates

Comment 4 2019-08-02 11:49:55 PDT

Created attachment 375438 [details] Tooltip when you hover over Mac-wk2 bubble

Aakash Jain

Comment 5 2019-08-02 12:07:03 PDT

This is true for patches since April (when new EWS started building patches on ios and mac) e.g.: https://bugs.webkit.org/show_bug.cgi?id=198058

Aakash Jain

Comment 6 2019-08-02 12:13:51 PDT

Note that we haven't yet moved WK1 queues to production yet, so kindly ignore the buildbot page showing WK1 build triggers.

Aakash Jain

Comment 7 2019-08-02 12:14:40 PDT

We moved mac-wk2 queue to production only 2 days back, so it wouldn't be processing any older patches. Ideally these bubbles should be hidden, since those patch were uploaded before the queue started in production. After the change in bug 200333, the tester queues started showing information from builder queue as well (while tester queue hasn't started processing it). This has an unintentional side-effect of showing bubbles which should have been hidden.

Aakash Jain

Comment 8 2019-08-02 12:17:24 PDT

For bug #199960 I have pressed the 'Rebuild' button on the corresponding build (https://ews-build.webkit.org/#/builders/7/builds/5822), so mac-wk2 queue should process it now.

Aakash Jain

Comment 9 2019-08-05 13:33:42 PDT

*** Bug 200443 has been marked as a duplicate of this bug. ***

Aakash Jain

Comment 10 2019-08-05 13:36:47 PDT

Created attachment 375549 [details] Patch

Aakash Jain

Comment 11 2019-08-05 13:39:44 PDT

(In reply to Aakash Jain from comment #10) > Created attachment 375549 [details] > Patch This fix is similar to https://trac.webkit.org/changeset/244930/webkit That one applies to builder queues. The triggered queues take a different code-path, as they check for parent_build (build on builder queue), and so do not use the _queue_position() method if parent_build is found.

WebKit Commit Bot

Comment 12 2019-08-05 14:24:57 PDT

Comment on attachment 375549 [details] Patch Clearing flags on attachment: 375549 Committed r248272: <https://trac.webkit.org/changeset/248272>

WebKit Commit Bot

Comment 13 2019-08-05 14:24:59 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.