Bug 200365

Summary: Add build check for libwebrtc ObjectiveC names
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, ddkilzer, eric.carlson, ews-watchlist, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=200289
Bug Depends on: 200393    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Fixing build
none
Fixing changelog none

youenn fablet
Reported 2019-08-01 15:51:43 PDT
Add build check for libwebrtc ObjectiveC names
Attachments
Patch (2.48 KB, patch)
2019-08-01 15:55 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Fixing build (2.44 KB, patch)
2019-08-02 10:35 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Fixing changelog (2.44 KB, patch)
2019-08-02 11:11 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-08-01 15:55:55 PDT
Created attachment 375359 [details] Patch
WebKit Commit Bot
Comment 2 2019-08-02 10:04:21 PDT
Comment on attachment 375359 [details] Patch Clearing flags on attachment: 375359 Committed r248156: <https://trac.webkit.org/changeset/248156>
WebKit Commit Bot
Comment 3 2019-08-02 10:04:22 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-08-02 10:05:19 PDT
<rdar://problem/53867716>
WebKit Commit Bot
Comment 5 2019-08-02 10:29:37 PDT
Re-opened since this is blocked by bug 200393
youenn fablet
Comment 6 2019-08-02 10:35:30 PDT
Created attachment 375422 [details] Fixing build
WebKit Commit Bot
Comment 7 2019-08-02 10:37:43 PDT
Comment on attachment 375422 [details] Fixing build Rejecting attachment 375422 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 375422, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/ThirdParty/libwebrtc/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/12852794
youenn fablet
Comment 8 2019-08-02 11:11:13 PDT
Created attachment 375429 [details] Fixing changelog
WebKit Commit Bot
Comment 9 2019-08-02 11:47:34 PDT
Comment on attachment 375429 [details] Fixing changelog Clearing flags on attachment: 375429 Committed r248165: <https://trac.webkit.org/changeset/248165>
WebKit Commit Bot
Comment 10 2019-08-02 11:47:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.