Bug 200328

Summary: [WHLSL] Replace memsetZero function with inline "= { }" code
Product: WebKit Reporter: Saam Barati <saam>
Component: WebGPUAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, fpizlo, jonlee, justin_fan, mmaxfield, rmorisset, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
rmorisset: review+
patch for landing none

Saam Barati
Reported 2019-07-31 18:40:31 PDT
inline "x = { 0 };" instead. This is a metal compile time speedup
Attachments
patch (5.02 KB, patch)
2019-07-31 18:51 PDT, Saam Barati 		rmorisset: review+
DetailsFormatted DiffDiff
patch for landing (5.02 KB, patch)
2019-07-31 21:21 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2019-07-31 18:51:54 PDT
Created attachment 375277 [details] patch
Robin Morisset
Comment 2 2019-07-31 18:52:48 PDT
Comment on attachment 375277 [details] patch r=me
Saam Barati
Comment 3 2019-07-31 21:01:06 PDT
Comment on attachment 375277 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=375277&action=review > Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp:587 > + "else ", variableName, " = { 0 };\n" these need to be "= {}" instead of = "{ 0 }" to also work with enums.
Saam Barati
Comment 4 2019-07-31 21:21:01 PDT
Created attachment 375290 [details] patch for landing
WebKit Commit Bot
Comment 5 2019-07-31 22:17:49 PDT
Comment on attachment 375290 [details] patch for landing Clearing flags on attachment: 375290 Committed r248096: <https://trac.webkit.org/changeset/248096>
WebKit Commit Bot
Comment 6 2019-07-31 22:17:50 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-07-31 22:18:19 PDT
<rdar://problem/53797375>
Note You need to log in before you can comment on or make changes to this bug.