Web Inspector: Uncaught Exception: TypeError: null is not an object (evaluating 'issueMessage.sourceCodeLocation.sourceCode')

• Component: Web Inspector
• Status: RESOLVED FIXED

[Devin Rousso]

-------
Inspected URL:        https://www.youtube.com/user/NewOnNetflix/videos
Loading completed:    true
Frontend User Agent:  Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15) AppleWebKit/605.1.15 (KHTML, like Gecko)

Uncaught Exceptions:
 - TypeError: null is not an object (evaluating 'issueMessage.sourceCodeLocation.sourceCode') (at DebuggerSidebarPanel.js:1406:111)
    _addIssue @ DebuggerSidebarPanel.js:1406:111
    _addIssuesForSourceCode @ DebuggerSidebarPanel.js:587:27
    _addResource @ DebuggerSidebarPanel.js:640:37
    _addResourcesRecursivelyForFrame @ DebuggerSidebarPanel.js:619:26
    DebuggerSidebarPanel @ DebuggerSidebarPanel.js:224:50
    navigationSidebarPanel @ TabContentView.js:171:87
    shown @ ContentBrowserTabContentView.js:101:17
    prepareToShow @ BackForwardEntry.js:84:35
    _showEntry @ ContentViewContainer.js:450:28
    showBackForwardEntryForIndex @ ContentViewContainer.js:166:28
    showContentView @ ContentViewContainer.js:142:42
    _tabBarItemSelected @ TabBrowser.js:238:55
    dispatch @ Object.js:165:30
    dispatchEventToListeners @ Object.js:172:17
    selectedTabBarItem @ LegacyTabBar.js:385:38
    _handleMouseDown @ LegacyTabBar.js:634:13
    _handleMouseDown @ [native code]
-------

* STEPS TO REPRODUCE
1. set a specific event listener breakpoint for every event listener on `#menu > a:nth-child(2) > paper-item > paper-item-body > div.item.style-scope.yt-dropdown-menu`.
2. disable all event listeners of every parent
3. tap the node

[Devin Rousso]

Created attachment 375217 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 375217 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375217&action=review

r=me

> Source/WebInspectorUI/ChangeLog:10
> +        we should pass the `WI.SourceCode` along in that case, and use it when creating a associated

Grammar: "a associate" => "an association"

> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:1407
> +        if (!sourceCode && !issueMessage.sourceCodeLocation)
> +            return null;

Can this ever happen? Could this just become an assert.

Seems the `debuggerObject` case is the only time this could happen.

[Devin Rousso]

Comment on attachment 375217 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375217&action=review

>> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:1407
>> +            return null;
> 
> Can this ever happen? Could this just become an assert.
> 
> Seems the `debuggerObject` case is the only time this could happen.

I don't think it can happen, because the `debuggerObject` path already checks for `debuggerObject.sourceCodeLocation.displaySourceCode`, so it should be valid there too.  I'll change it to an assert.

[Devin Rousso]

Created attachment 375288 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 375288 [details]
Patch

Clearing flags on attachment: 375288

Committed r248094: <https://trac.webkit.org/changeset/248094>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/53796065>